linux-kernel - Re: [PATCH net-next] net: dlink: add get_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAjsZQxAqj=r4tJkWnZKxY9MC2a5d7_7HsVTcmJk5kjehT8uGg@mail.gmail.com>
Date: Tue, 29 Oct 2024 17:30:37 +0900
From: Moon Yeounsu <yyyynoom@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dlink: add get_ethtool_stats in ethtool

Hi Andrew,

Thank you for your feedback.

I'll post the next patch with an exact explanation of what is
happening here, especially concerning the deletions and additions. As
you pointed out, there is a considerable amount of code being removed
even as new functionality is added. Additionally, I discovered some
duplicate logic that still remains, which will need to be removed in a
future patch. Apologies for not catching this earlier.

Regarding the RMON statistics, I understand that you are advising me
to use the structured ethtool_rmon_stats for RMON statistics and to
reserve unstructured ethtool -S (without groups) for non-standard
statistics. The documentation[1] specifies grouping RMON statistics,
but there are other statistics in my patch that are not part of the
RMON. Would it be appropriate to group these additional statistics as
well?

Thank you, Yeounsu Moon

[1]: https://www.kernel.org/doc/Documentation/networking/statistics.rst