linux-kernel - [PATCH] Fix unused variable warning in 'drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241029102234.187480-1-gye976@gmail.com>
Date: Tue, 29 Oct 2024 19:22:34 +0900
From: Gyeyoung Baek <gye976@...il.com>
To: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>
Cc: Gyeyoung Baek <gye976@...il.com>,
	dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] Fix unused variable warning in 'drm_print.h'

previous code can make unused variable warning,

e.g. when CONFIG_DRM_USE_DYNAMIC_DEBUG is set,
this outputs the following build error.

drivers/gpu/drm/drm_print.c: In function ‘__drm_printfn_dbg’:
drivers/gpu/drm/drm_print.c:218:33: error: unused variable ‘category’ [-Werror=unused-variable]
  218 |         enum drm_debug_category category = p->category;



so i simply add '(void)(category);' to remove unused variable warning,
by referring to "https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html".

Signed-off-by: Gyeyoung Baek <gye976@...il.com>
---
 include/drm/drm_print.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index d2676831d765..6a5dc1f73ff2 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -157,7 +157,7 @@ static inline bool drm_debug_enabled_raw(enum drm_debug_category category)
  * a descriptor, and only enabled callsites are reachable.  They use
  * the private macro to avoid re-testing the enable-bit.
  */
-#define __drm_debug_enabled(category)	true
+#define __drm_debug_enabled(category)	({ (void)(category); true; })
 #define drm_debug_enabled(category)	drm_debug_enabled_instrumented(category)
 #else
 #define __drm_debug_enabled(category)	drm_debug_enabled_raw(category)
-- 
2.34.1