linux-kernel - Re: [PATCHv2 2/2] zram: clear IDLE flag in mark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241029000954.GU1279924@google.com>
Date: Tue, 29 Oct 2024 09:09:54 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Brian Geffon <bgeffon@...gle.com>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Minchan Kim <minchan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 2/2] zram: clear IDLE flag in mark_idle()

On (24/10/28 13:57), Brian Geffon wrote:
> On Tue, Oct 29, 2024 at 12:36:15AM +0900, Sergey Senozhatsky wrote:
> > If entry does not fulfill current mark_idle() parameters, e.g.
> > cutoff time, then we should clear its ZRAM_IDLE from previous
> > mark_idle() invocations.
> >
> > Consider the following case:
> > - mark_idle() cutoff time 8h
> > - mark_idle() cutoff time 4h
> > - writeback() idle - will writeback entries with cutoff time 8h,
> >   while it should only pick entries with cutoff time 4h
> >
> > The bug was reported by Shin Kawamura.
> Reported-by: Shin Kawamura <kawasin@...gle.com>

This is how it was in v1, but that triggered a warn

    WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
    #16:
    Reported-by: Shin Kawamura <kawasin@...gle.com>
    Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org>

so I switched to less "formal" reported-by tag in v2.