linux-kernel - Re: [PATCH] clk: starfive: jh7110-pll: Mark the probe function as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJM55Z9-xrKuH3eS3hUjDMv8JEabBZRR48oQmhv7yghtiG0cFg@mail.gmail.com>
Date: Tue, 29 Oct 2024 07:10:25 -0400
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>, 
	Emil Renner Berthing <kernel@...il.dk>, Hal Feng <hal.feng@...rfivetech.com>, 
	Xingyu Wu <xingyu.wu@...rfivetech.com>, Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: starfive: jh7110-pll: Mark the probe function as __init

Changhuang Liang wrote:
> Mark the jh7110_pll_probe function as __init.
>
> There's no need to support hotplugging in the jh7110-pll driver. We use
> builtin_platform_driver_probe, the probe function will only be called at
> startup.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>

Makse sense to me, thanks.

Reviewed-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>

> ---
>  drivers/clk/starfive/clk-starfive-jh7110-pll.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/starfive/clk-starfive-jh7110-pll.c b/drivers/clk/starfive/clk-starfive-jh7110-pll.c
> index 3598390e8fd0..56dc58a04f8a 100644
> --- a/drivers/clk/starfive/clk-starfive-jh7110-pll.c
> +++ b/drivers/clk/starfive/clk-starfive-jh7110-pll.c
> @@ -453,7 +453,7 @@ static struct clk_hw *jh7110_pll_get(struct of_phandle_args *clkspec, void *data
>  	return ERR_PTR(-EINVAL);
>  }
>
> -static int jh7110_pll_probe(struct platform_device *pdev)
> +static int __init jh7110_pll_probe(struct platform_device *pdev)
>  {
>  	struct jh7110_pll_priv *priv;
>  	unsigned int idx;
> --
> 2.25.1
>