linux-kernel - Re: [PATCH 0/2] platform/x86: asus-wmi: Fix thermal profile handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DS0PR11MB8184A4A4746815462B2C220ADD4B2@DS0PR11MB8184.namprd11.prod.outlook.com>
Date: Tue, 29 Oct 2024 01:19:05 +0000
From: "Bowman, Casey G" <casey.g.bowman@...el.com>
To: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>, Armin Wolf
	<W_Armin@....de>, "corentin.chary@...il.com" <corentin.chary@...il.com>,
	"luke@...nes.dev" <luke@...nes.dev>, "Ghanmi, Mohamed"
	<mohamed.ghanmi@...com.tn>
CC: "hdegoede@...hat.com" <hdegoede@...hat.com>,
	"ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
	"Michael@...ronix.com" <Michael@...ronix.com>,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] platform/x86: asus-wmi: Fix thermal profile handling


Ran a quick test with the two patches on top of drm-tip while monitoring the sensor's temperature as well as thermald logs.

While running "stress -c 8" for around two minutes for each mode, I can see the SEN1 temperature plateau at the expected areas for the various power modes:

- Power Saver
    - Max temp observed: 51 C
    - Trip temperature: 51 C

- Balanced
    - Max temp observed: 56 C
    - Trip temperature: 56 C

- Performance
    - Max temp observed: 61 C
    - Trip temperature: 61 C

Cycling from higher power modes to lower power modes works as expected, with the temperatures falling back to the peak values listed for the given mode.

>From my observations, these patches are working as intended.

Regards,
Casey

________________________________________
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
Sent: Friday, October 25, 2024 9:09 PM
To: Armin Wolf <W_Armin@....de>; corentin.chary@...il.com <corentin.chary@...il.com>; luke@...nes.dev <luke@...nes.dev>; Ghanmi, Mohamed <mohamed.ghanmi@...com.tn>; Bowman, Casey G <casey.g.bowman@...el.com>
Cc: hdegoede@...hat.com <hdegoede@...hat.com>; ilpo.jarvinen@...ux.intel.com <ilpo.jarvinen@...ux.intel.com>; Michael@...ronix.com <Michael@...ronix.com>; Bowman, Casey G <casey.g.bowman@...el.com>; platform-driver-x86@...r.kernel.org <platform-driver-x86@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] platform/x86: asus-wmi: Fix thermal profile handling
 
+Casey

On Fri, 2024-10-25 at 21:15 +0200, Armin Wolf wrote:
> When support for Vivobook fan profiles was added, two mistakes where
> made:
>
> 1. throttle_thermal_policy_set_default() was not called anymore
> during
> probe.
>
> 2. The new thermal profiles where used inconsistently.
>
> This patch series aims to fix both issues. Compile-tested only.
>
Thanks for these patches. The first one I already tested with the same
change, for the second one added Casey to check if he can give a quick
test for both on the new Asus Lunar Lake laptop.

Thanks,
Srinivas




> Armin Wolf (2):
>   platform/x86: asus-wmi: Fix thermal profile initialization
>   platform/x86: asus-wmi: Fix inconsistent use of thermal policies
>
>  drivers/platform/x86/asus-wmi.c | 74 ++++++++++++++-----------------
> --
>  1 file changed, 31 insertions(+), 43 deletions(-)
>
> --
> 2.39.5
>