[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c902dc2a-9b2a-44a0-be1d-88fb150f4f17@lunn.ch>
Date: Tue, 29 Oct 2024 13:15:52 +0100
From: Andrew Lunn <andrew@...n.ch>
To: jan.petrous@....nxp.com
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Vinod Koul <vkoul@...nel.org>,
Richard Cochran <richardcochran@...il.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Emil Renner Berthing <kernel@...il.dk>,
Minda Chen <minda.chen@...rfivetech.com>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
Iyappan Subramanian <iyappan@...amperecomputing.com>,
Keyur Chudgar <keyur@...amperecomputing.com>,
Quan Nguyen <quan@...amperecomputing.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, linux-arm-msm@...r.kernel.org,
imx@...ts.linux.dev, devicetree@...r.kernel.org,
NXP S32 Linux Team <s32@....com>
Subject: Re: [PATCH v4 14/16] net: stmmac: dwmac-s32: add basic NXP S32G/S32R
glue driver
> +#define GMAC_TX_RATE_125M 125000000 /* 125MHz */
> +#define GMAC_TX_RATE_25M 25000000 /* 25MHz */
> +#define GMAC_TX_RATE_2M5 2500000 /* 2.5MHz */
With the swap to the new helper, i think 25M and 2M5 are no longer
needed.
> +static int s32_gmac_init(struct platform_device *pdev, void *priv)
> +{
> + struct s32_priv_data *gmac = priv;
> + int ret;
> +
> + ret = clk_set_rate(gmac->tx_clk, GMAC_TX_RATE_125M);
> + if (!ret)
> + ret = clk_prepare_enable(gmac->tx_clk);
> +
> + if (ret) {
> + dev_err(&pdev->dev, "Can't set tx clock\n");
> + return ret;
> + }
> +
> + ret = clk_prepare_enable(gmac->rx_clk);
> + if (ret)
> + dev_dbg(&pdev->dev, "Can't set rx, clock source is disabled.\n");
> + else
> + gmac->rx_clk_enabled = true;
Why would this fail? And if it does fail, why is it not fatal? Maybe a
comment here.
> +static void s32_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode)
> +{
> + struct s32_priv_data *gmac = priv;
> + long tx_clk_rate;
> + int ret;
> +
> + if (!gmac->rx_clk_enabled) {
> + ret = clk_prepare_enable(gmac->rx_clk);
> + if (ret) {
> + dev_err(gmac->dev, "Can't set rx clock\n");
dev_err(), so is failing now fatal, but since this is a void function,
you cannot report the error up the call stack?
Andrew
Powered by blists - more mailing lists