[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241029013055.45538-3-towinchenmi@gmail.com>
Date: Tue, 29 Oct 2024 09:29:18 +0800
From: Nick Chan <towinchenmi@...il.com>
To: Hector Martin <marcan@...can.st>,
Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
asahi@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org,
linux-watchdog@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Nick Chan <towinchenmi@...il.com>
Subject: [PATCH v2 RESEND 2/2] watchdog: apple: Increase reset delay to 150ms
The Apple A8X SoC seems to be slowest at resetting, taking up to around
125ms to reset. Wait 150ms to be safe here.
Reviewed-by: Sven Peter <sven@...npeter.dev>
Reviewed-by: Guenter Roeck <linux@...ck-us.net>
Signed-off-by: Nick Chan <towinchenmi@...il.com>
---
drivers/watchdog/apple_wdt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c
index 62dabf223d90..95d9e37df41c 100644
--- a/drivers/watchdog/apple_wdt.c
+++ b/drivers/watchdog/apple_wdt.c
@@ -127,11 +127,11 @@ static int apple_wdt_restart(struct watchdog_device *wdd, unsigned long mode,
/*
* Flush writes and then wait for the SoC to reset. Even though the
* reset is queued almost immediately experiments have shown that it
- * can take up to ~20-25ms until the SoC is actually reset. Just wait
- * 50ms here to be safe.
+ * can take up to ~120-125ms until the SoC is actually reset. Just
+ * wait 150ms here to be safe.
*/
(void)readl(wdt->regs + APPLE_WDT_WD1_CUR_TIME);
- mdelay(50);
+ mdelay(150);
return 0;
}
--
2.47.0
Powered by blists - more mailing lists