linux-kernel - Re: [PATCH v2 2/2] arm64: dts: qcom: sa8775p-ride: Enable Display Port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA8EJprTc=kviF=MYQFqnE4g0Xk+jmT96=ihm3D75Me1Yw-WQA@mail.gmail.com>
Date: Tue, 29 Oct 2024 15:00:11 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Soutrik Mukhopadhyay <quic_mukhopad@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	quic_riteshk@...cinc.com, quic_vproddut@...cinc.com, 
	quic_abhinavk@...cinc.com
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sa8775p-ride: Enable Display Port

On Tue, 29 Oct 2024 at 08:08, Soutrik Mukhopadhyay
<quic_mukhopad@...cinc.com> wrote:
>
>
> On 10/28/2024 3:15 PM, Dmitry Baryshkov wrote:
> > On Mon, 28 Oct 2024 at 10:49, Soutrik Mukhopadhyay
> > <quic_mukhopad@...cinc.com> wrote:
> >>
> >> On 10/8/2024 5:46 PM, Dmitry Baryshkov wrote:
> >>> On Tue, Oct 08, 2024 at 04:55:16PM GMT, Soutrik Mukhopadhyay wrote:
> >>>> Enable DPTX0 and DPTX1 along with their corresponding PHYs for
> >>>> sa8775p-ride platform.
> >>> What is connected to those DP lanes? If they are routed directly to the
> >>> DisplayPort connectors, please add corresponding devices (see
> >>> dp-connector).
> >>
> >> We are defining the functionality of gpio101 and gpio102 as "edp0_hot"
> >> and "edp1_hot"
> >>
> >> respectively. This ensures that the hot plug will be directly routed via
> >> the display interrupt
> >>
> >> line "mdss0" to the display port driver and no external dependencies on
> >> dp-connector is
> >>
> >> necessary.
> > Please describe the hardware, not the driver necessities.
> > If the board has a DP connector, please add the node. E.g. it allows
> > one to specify the label and the type used by the connector.
> >
> > Also could you please fix your email client so that you don't have
> > strange/unnecessary line wraps and empty lines?
>
> Addition of DP connector node with the hpd-gpio property does not allow
> hpd to be detected since the gpio
>
> 101/102 have the "edp0_hot" as function. If the hpd-gpio property is
> removed from the DP connector node,
>
> the probe of DP connector will fail.

No, it wont. It uses devm_gpiod_get_optional(). And if it does fail,
it is a bug which needs to be fixed.

And please, fix your email client so that it doesn't insert stray empty lines.

-- 
With best wishes
Dmitry