| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <208bef7b-1097-4c81-80ae-fc50d71cb7e5@kernel.org> Date: Tue, 29 Oct 2024 14:49:44 +0100 From: Krzysztof Kozlowski <krzk@...nel.org> To: Mirela Rabulea <mirela.rabulea@....com>, mchehab@...nel.org, sakari.ailus@...ux.intel.com, hverkuil-cisco@...all.nl, laurent.pinchart+renesas@...asonboard.com, laurentiu.palcu@....com, robert.chiras@....com Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, LnxRevLi@....com, kieran.bingham@...asonboard.com, hdegoede@...hat.com, dave.stevenson@...pberrypi.com, mike.rudenko@...il.com, alain.volmat@...s.st.com, julien.vuillaumier@....com, alice.yuan@....com Subject: Re: [EXT] Re: [PATCH 1/5] dt-bindings: media: i2c: Add bindings for OX05B1S sensor driver On 29/10/2024 14:36, Mirela Rabulea wrote: >> >> Binding also looks very different than all other devices, so re-write it >> starting from EXISTING GOOD bindings. Not some downstream stuff. > Would this be a good example? > Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml Yes, looks good. >> >> A nit, subject: drop second/last, redundant "bindings". The >> "dt-bindings" prefix is already stating that these are bindings. >> See also: >> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 >> >> A nit, subject: drop second/last "driver". Bindings are for hardware, >> not drivers. > Please correct the example so it matches coding style. Just compare how your DTS and imx DTS look like. Best regards, Krzysztof
Powered by blists - more mailing lists