linux-kernel - Re: [PATCH v6 8/9] platform/x86: asus-armoury: add core count control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <fa72f965-b265-425c-aa88-c15d311121a0@app.fastmail.com>
Date: Wed, 30 Oct 2024 15:55:52 +0100
From: "Luke Jones" <luke@...nes.dev>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-input@...r.kernel.org,
 "Jiri Kosina" <jikos@...nel.org>, platform-driver-x86@...r.kernel.org,
 "Hans de Goede" <hdegoede@...hat.com>, corentin.chary@...il.com,
 "Mario Limonciello" <superm1@...nel.org>,
 "Mario Limonciello" <mario.limonciello@....com>
Subject: Re: [PATCH v6 8/9] platform/x86: asus-armoury: add core count control



On Wed, 30 Oct 2024, at 3:14 PM, Ilpo Järvinen wrote:
> On Wed, 30 Oct 2024, Luke Jones wrote:
>
>> Hello,
>> 
>> On Thu, 17 Oct 2024, at 4:41 PM, Ilpo Järvinen wrote:
>> > On Mon, 30 Sep 2024, Luke D. Jones wrote:
>> >
>> >> Implement Intel core enablement under the asus-armoury module using the
>> >> fw_attributes class.
>> >> 
>> >> This allows users to enable or disable preformance or efficiency cores
>> >> depending on their requirements. After change a reboot is required.
>> >> 
>> >> Signed-off-by: Luke D. Jones <luke@...nes.dev>
>> >> Reviewed-by: Mario Limonciello <mario.limonciello@....com>
>> >> ---
>> >>  drivers/platform/x86/asus-armoury.c        | 227 +++++++++++++++++++++
>> >>  drivers/platform/x86/asus-armoury.h        |  28 +++
>> >>  include/linux/platform_data/x86/asus-wmi.h |   4 +
>> >>  3 files changed, 259 insertions(+)
>> >> 
>> >> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
>> >> index 09e0cbf24f25..caaa55219946 100644
>> >> --- a/drivers/platform/x86/asus-armoury.c
>> >> +++ b/drivers/platform/x86/asus-armoury.c
>> >> @@ -40,6 +40,24 @@
>> >>  #define ASUS_MINI_LED_2024_STRONG 0x01
>> >>  #define ASUS_MINI_LED_2024_OFF 0x02
>> >>  
>> >> +#define ASUS_POWER_CORE_MASK GENMASK(15, 8)
>> >> +#define ASUS_PERF_CORE_MASK GENMASK(7, 0)
>> >
>> > Align GENMASK()s.
>> 
>> That is how clang-format put them using the .clang-format in the repo. 
>> I'm not keen on maintaining style manually as it inevitably develops 
>> inconsistency. 
>
> Hi Luke,
>
> Then you simply create your own clang-format and put 
> AlignConsecutiveMacros into it.
>
> I'm not buying using a kernel-wide .clang-format as an argument because 
> there are per subsystem variations in various coding style aspects a 
> single file is never going to capture. It also has ColumnLimit: 80 which
> is explicitly stated by Linus to not be a rigid rule so that alone proves 
> your argument is on very shallow grounds.
>
> The commit that introduced the file states: "Like most tools, it is not 
> perfect nor covers every single case, but it is good enough to be 
> helpful." It's a big set from "being helpful" to "I want to strictly 
> follow what it outputs". I believe that file is there to help you out if 
> you want to get started with the style but it does not guaranteed its 
> output is accepted as is, you will have to tweak its configuration to get 
> the desired output here and there if you want to use on daily basis.

Understood. I'll adjust things to suit.

> -- 
>  i.