[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8a68babc-b4f5-42f2-bc93-ce8f1b7a14e1@roeck-us.net>
Date: Wed, 30 Oct 2024 08:02:55 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Akinobu Mita <akinobu.mita@...il.com>,
Billy Tsai <billy_tsai@...eedtech.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Jean Delvare <jdelvare@...e.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2 1/2] hwmon: (pwm-fan) add option to leave fan on
shutdown
On 10/30/24 07:55, Akinobu Mita wrote:
> 2024年10月29日(火) 11:35 Billy Tsai <billy_tsai@...eedtech.com>:
>>
>>> This adds an optional property "retain-state-shutdown" as requested by
>>> Billy Tsai.
>>
>>> Billy said:
>>> "Our platform is BMC that will use a PWM-FAN driver to control the fan
>>> on the managed host. In our case, we do not want to stop the fan when
>>> the BMC is reboot, which may cause the temperature of the managed host
>>> not to be lowered."
>>
>> I confirmed that it works properly.
>>
>> Reviewed-by: Billy Tsai <billy_tsai@...eedtech.com>
>> Tested-by: Billy Tsai <billy_tsai@...eedtech.com>
>
> Thank you very much for testing.
> However, I plan to change this option to device attribute
> (/sys/class/hwmon/hwmonX/retain-state-shutdown) instead of the device tree.
No, I won't acccept that.
Guenter
Powered by blists - more mailing lists