linux-kernel - Re: [PATCH 05/21] can: bcm: Don't initialized an unused hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o731y5z8.ffs@tglx>
Date: Wed, 30 Oct 2024 16:18:19 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Oliver Hartkopp <socketcan@...tkopp.net>, Nam Cao <namcao@...utronix.de>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker
 <frederic@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Alice
 Ryhl <aliceryhl@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, Kees Cook
 <kees@...nel.org>, linux-kernel@...r.kernel.org, Jakub Kicinski
 <kuba@...nel.org>
Subject: Re: [PATCH 05/21] can: bcm: Don't initialized an unused hrtimer

On Wed, Oct 30 2024 at 16:01, Oliver Hartkopp wrote:

> Just an additional idea:
>
> Would it probably make sense to create a generic dummy function for all 
> those cases like in the referenced rt2x00 driver?
>
> E.g. as (inline?) function in hrtimer.h
>
> enum hrtimer_restart hrtimer_nop_callback(struct hrtimer *timer)
> {
> 	return HRTIMER_NORESTART;
> }

Yes.