linux-kernel - Re: [PATCH v2 1/2] hwmon: (pwm-fan) add option to leave fan on shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyjtyuf8ECxhX+QeqQKb9+8emPU4omxw6V5JizAQMaGhCg@mail.gmail.com>
Date: Thu, 31 Oct 2024 00:18:37 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Billy Tsai <billy_tsai@...eedtech.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Jean Delvare <jdelvare@...e.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2 1/2] hwmon: (pwm-fan) add option to leave fan on shutdown

2024年10月31日(木) 0:02 Guenter Roeck <linux@...ck-us.net>:
>
> On 10/30/24 07:55, Akinobu Mita wrote:
> > 2024年10月29日(火) 11:35 Billy Tsai <billy_tsai@...eedtech.com>:
> >>
> >>> This adds an optional property "retain-state-shutdown" as requested by
> >>> Billy Tsai.
> >>
> >>> Billy said:
> >>>   "Our platform is BMC that will use a PWM-FAN driver to control the fan
> >>>   on the managed host. In our case, we do not want to stop the fan when
> >>>   the BMC is reboot, which may cause the temperature of the managed host
> >>>   not to be lowered."
> >>
> >> I confirmed that it works properly.
> >>
> >> Reviewed-by: Billy Tsai <billy_tsai@...eedtech.com>
> >> Tested-by: Billy Tsai <billy_tsai@...eedtech.com>
> >
> > Thank you very much for testing.
> > However, I plan to change this option to device attribute
> > (/sys/class/hwmon/hwmonX/retain-state-shutdown) instead of the device tree.
>
>
> No, I won't acccept that.

Oops, I mean /sys/device/platform/pwm-fan.X/retain-state-shutdown
not /sys/class/hwmon/hwmonX/retain-state-shutdown.