linux-kernel - Re: [PATCH 2/2] btrfs: simplify regions mark and keep start unchanged in err handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241030152836.GA31418@twin.jikos.cz>
Date: Wed, 30 Oct 2024 16:28:36 +0100
From: David Sterba <dsterba@...e.cz>
To: Qu Wenruo <quwenruo.btrfs@....com>
Cc: iamhswang@...il.com, linux-btrfs@...r.kernel.org, clm@...com,
	josef@...icpanda.com, dsterba@...e.com, wqu@...e.com, boris@....io,
	linux-kernel@...r.kernel.org, Haisu Wang <haisuwang@...cent.com>
Subject: Re: [PATCH 2/2] btrfs: simplify regions mark and keep start
 unchanged in err handling

On Wed, Oct 30, 2024 at 01:31:15PM +1030, Qu Wenruo wrote:
> 
> 
> 在 2024/10/25 17:24, iamhswang@...il.com 写道:
> > From: Haisu Wang <haisuwang@...cent.com>
> >
> > Simplify the regions mark by using cur_alloc_size only to present
> > the reserved but may failed to alloced extent. Remove the ram_size
> > as well since it is always consistent to the cur_alloc_size in the
> > context. Advanced the start mark in normal path until extent succeed
> > alloced and keep the start unchanged in error handling path.
> >
> > PASSed the fstest generic/475 test for a hundred times with quota
> > enabled. And a modified generic/475 test by removing the sleep time
> > for a hundred times. About one tenth of the tests do enter the error
> > handling path due to fail to reserve extent.
> >
> 
> Although this patch is already merged into for-next, it looks like the
> next patch will again change the error handling, mostly render the this
> one useless:
> 
> https://lore.kernel.org/linux-btrfs/2a0925f0264daf90741ed0a7ba7ed4b4888cf778.1728725060.git.wqu@suse.com/
> 
> The newer patch will change the error handling to a simpler one, so
> instead of 3 regions, there will be only 2.
> 
> There will be no change needed from your side, I will update my patches
> to solve the conflicts, just in case if you find the error handling is
> different in the future.

Please take care of that, the only request I have is that it's done by
the end of this week so we have the code in linux-next and that a fix
should come before a refactoring (due to backports). Update for-next as
you need.