linux-kernel - Re: [PATCH net-next 0/4] mptcp: various small improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66de4e7f-96bc-461b-81ca-5182d55308b1@kernel.org>
Date: Wed, 30 Oct 2024 18:07:36 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: mptcp@...ts.linux.dev, Mat Martineau <martineau@...nel.org>,
 Geliang Tang <geliang@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Gang Yan <yangang@...inos.cn>, Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH net-next 0/4] mptcp: various small improvements

Hi Jakub,

On 30/10/2024 00:50, Jakub Kicinski wrote:
> On Mon, 21 Oct 2024 17:14:02 +0200 Matthieu Baerts (NGI0) wrote:
>> The following patches are not related to each other.
>>
>> - Patch 1: Avoid sending advertisements on stale subflows, reducing
>>   risks on loosing them.
>>
>> - Patch 2: Annotate data-races around subflow->fully_established, using
>>   READ/WRITE_ONCE().
>>
>> - Patch 3: A small clean-up on the PM side, avoiding a bit of duplicated
>>   code.
>>
>> - Patch 4: Use "Middlebox interference" MP_TCPRST code in reaction to a
>>   packet received without MPTCP options in the middle of a connection.
> 
> Could be a coincidence but looks like we got two flakes in mptcp-join
> since yesterday (different sub-cases).

Thank you for having reported this. It looks like a coincidence, but I
will monitor that.

> What's more sad is that it looks
> like our subcase parsing is broken, when I look at the subcase view
> all sub-cases are marked as passing :( Could you take a look?

I think the issue is with the 'retry' feature, when the nested tests are
parsed. I hope I fixed this in:

  https://github.com/linux-netdev/nipa/pull/43

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.