linux-kernel - Re: [PATCH v1 1/1] ACPI: battery: Check for error code from devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyJtXzIReSHfKkd_@smile.fi.intel.com>
Date: Wed, 30 Oct 2024 19:31:11 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thomas Weißschuh <thomas@...ssschuh.net>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Thomas Weißschuh <linux@...ssschuh.net>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1 1/1] ACPI: battery: Check for error code from
 devm_mutex_init() call

On Wed, Oct 30, 2024 at 10:42:18AM -0600, Thomas Weißschuh wrote:
> Oct 30, 2024 10:28:03 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:

...

> Assuming you found this via some sort of tool and you already fixed up all
> the other places in the tree missing these checks,

The tool is called `git grep`.

> wouldn't it make sense to mark devm_mutex_init() as __must_check?

It's macro, any idea how to do that for the macros?

...

> Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>

Thanks!

-- 
With Best Regards,
Andy Shevchenko