linux-kernel - Re: [PATCH v1 1/2] gpio: mpsse: Check for error code from devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyJt3U-YTpQYwLrq@smile.fi.intel.com>
Date: Wed, 30 Oct 2024 19:33:17 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mary Strodl <mstrodl@....rit.edu>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/2] gpio: mpsse: Check for error code from
 devm_mutex_init() call

On Wed, Oct 30, 2024 at 01:12:01PM -0400, Mary Strodl wrote:
> On Wed, Oct 30, 2024 at 05:30:26PM +0200, Andy Shevchenko wrote:

...

> > +	err = devm_mutex_init(dev, &priv->io_mutex);
> > +	if (err)
> > +		return err;
> > +
> > +	ret = devm_mutex_init(dev, &priv->irq_mutex);
> 
> I think this should be `err = `

Oh, I haven't compiled that for sure :-)

> Other than that, it looks good to me (I doubt you need this, but just in case):
> 
> Reviewed-by: Mary Strodl <mstrodl@....rit.edu>

Thanks, I will fix that, I dunno how I missed that because I carefully read
the code before adding the checks.

-- 
With Best Regards,
Andy Shevchenko