linux-kernel - Re: [PATCH 02/11] clk: qcom: clk-alpha-pll: Add support for dynamic update for slewing PLLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1e9f8ce-b8cb-40a8-a69f-9433073922f3@quicinc.com>
Date: Wed, 30 Oct 2024 23:22:08 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>,
        Abhishek Sahu <absahu@...eaurora.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon
	<will@...nel.org>
CC: Ajit Pandey <quic_ajipan@...cinc.com>,
        Imran Shaik
	<quic_imrashai@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        "Stephen Boyd" <sboyd@...eaurora.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 02/11] clk: qcom: clk-alpha-pll: Add support for dynamic
 update for slewing PLLs



On 10/19/2024 1:50 AM, Christophe JAILLET wrote:
>> +
>> +static int clk_alpha_pll_slew_update(struct clk_alpha_pll *pll)
>> +{
>> +    int ret = 0;
> 
> Nitpick: unneeded initialisation
> 

Will fix in the next patch.

>> +    u32 val;
>> +
>> +    regmap_update_bits(pll->clkr.regmap, PLL_MODE(pll), PLL_UPDATE, 
>> PLL_UPDATE);
>> +    regmap_read(pll->clkr.regmap, PLL_MODE(pll), &val);
>> +
>> +    ret = wait_for_pll_update(pll);
>> +    if (ret)
>> +        return ret;
>> +    /*
>> +     * Hardware programming mandates a wait of at least 570ns before 
>> polling the LOCK
>> +     * detect bit. Have a delay of 1us just to be safe.
>> +     */
>> +    mb();
>> +    udelay(1);
>> +
>> +    return wait_for_pll_enable_lock(pll);
>> +}
> 
> ...
> 
>> +static int clk_alpha_pll_slew_enable(struct clk_hw *hw)
>> +{
>> +    int rc;
>> +
>> +    rc = clk_alpha_pll_calibrate(hw);
>> +    if (rc)
>> +        return rc;
>> +
>> +    rc = clk_alpha_pll_enable(hw);
>> +
>> +    return rc;
> 
> Nitpick: return clk_alpha_pll_enable(hw);

Will fix in the next patch.

-- 
Thanks & Regards,
Taniya Das.