linux-kernel - Re: [PATCH] net: wireless: realtek/rtw89: Add check null return of kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1728e9f5-0d4c-481f-8f85-9e4d74ab4ee5@kylinos.cn>
Date: Wed, 30 Oct 2024 11:13:43 +0800
From: Pei Xiao <xiaopei01@...inos.cn>
To: Ping-Ke Shih <pkshih@...ltek.com>,
	Kalle Valo <kvalo@...nel.org>
Cc: Pei Xiao <xiaopei01@...inos.cn>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"xiaopeitux@...mail.com" <xiaopeitux@...mail.com>,
	"xiongxin@...inos.cn" <xiongxin@...inos.cn>
Subject: Re: [PATCH] net: wireless: realtek/rtw89: Add check null return of kmalloc



On 2024/10/30 08:35, Ping-Ke Shih wrote:
> Kalle Valo <kvalo@...nel.org> wrote:
>> Pei Xiao <xiaopei01@...inos.cn> writes:
>>
>>> kmalloc may fail, return might be NULL and will cause
>>> NULL pointer dereference later.
>>>
>>> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
>>
>> We use 'wifi: rtw89:' in the title, please check the documentation below
>> for more.
>>
> 
> A way to known subject prefix is to use git log with the files touched by
> this patch:
>     git log --oneline drivers/net/wireless/realtek/rtw89/coex.c
> 
> Also subject can point out specific function. Then my opinion is
>    "wifi: rtw89: coex: check NULL return of kmalloc in btc_fw_set_monreg()"
> 
hi Kalle Valo and Ping-Ke Shih,
Thanks,I will modify the commit information and add Fixes.Thanks for help.

Pei Xiao.