linux-kernel - Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241030162624.2ae779257e68264c4bec99fd@linux-foundation.org>
Date: Wed, 30 Oct 2024 16:26:24 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Joshua Hahn <joshua.hahnjy@...il.com>
Cc: Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...e.com>,
 nphamcs@...il.com, shakeel.butt@...ux.dev, roman.gushchin@...ux.dev,
 muchun.song@...ux.dev, tj@...nel.org, lizefan.x@...edance.com,
 mkoutny@...e.com, corbet@....net, lnyng@...a.com, cgroups@...r.kernel.org,
 linux-mm@...ck.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg

On Wed, 30 Oct 2024 16:43:42 -0400 Joshua Hahn <joshua.hahnjy@...il.com> wrote:

> I saw that it was merged into mm-unstable earlier yesterday. Would it
> be possible
> to add this block of text to the patch description right before the footnotes?
> 
> 3. Implementation Details:
> In the alloc / free hugetlb functions, we call lruvec_stat_mod_folio
> regardless of whether memcg accounts hugetlb. lruvec_stat_mod_folio
> keys off of folio->memcg which is only set up if the
> CGRP_ROOT_MEMORY_HUGETLB_ACCOUTING cgroup mount option is used, so
> it will not try to accumulate hugetlb unless the flag is set.
> This also ensures that memory.stat::hugetlb is the same as
> the share of memory.current that is used by hugetlb pages.

Thanks, done.

> And could you also update the list of signatures to reflect the
> responses on this version?
> Suggested-by: Nhat Pham <nphamcs@...il.com>
> Suggested-by: Shakeel Butt <shakeel.butt@...ux.dev>
> Suggested-by: Johannes Weiner <hannes@...xchg.org>
> Acked-by: Shakeel Butt <shakeel.butt@...ux.dev>
> Acked-by: Johannes Weiner <hannes@...xchg.org>
> Acked-by: Chris Down <chris@...isdown.name>
> Reviewed-by: Roman Gushchin <roman.gushchin@...ux.dev>
> Reviewed-by: Nhat Pham <nphamcs@...il.com>
> Signed-off-by: Joshua Hahn <joshua.hahnjy@...il.com>

Done2.  I already had all that, plus an ack from Chris Down.