linux-kernel - Re: [PATCH v2] gpio: omap: Add omap_gpio_disable/enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0f15446-2e31-4776-84ec-99d96f65ef48@ti.com>
Date: Wed, 30 Oct 2024 18:41:22 -0500
From: Judith Mendez <jm@...com>
To: Santosh Shilimkar <ssantosh@...nel.org>, Kevin Hilman <khilman@...nel.org>
CC: Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski
	<brgl@...ev.pl>, <linux-omap@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Bin Liu <b-liu@...com>
Subject: Re: [PATCH v2] gpio: omap: Add omap_gpio_disable/enable_irq calls

Hi all,

Please ignore this patch, will resend this patch
with fixed recipients in the "to" list.

Apologies for the noise.

~ Judith


On 10/30/24 5:59 PM, Judith Mendez wrote:
> Add omap_gpio_disable_irq and omap_gpio_enable_irq
> calls in gpio-omap.
> 
> Currently, kernel cannot disable gpio interrupts in
> case of a irq storm, so add omap_gpio_disable/enable_irq
> so that interrupts can be disabled/enabled.
> 
> Signed-off-by: Bin Liu <b-liu@...com>
> [Judith: Add commit message]
> Signed-off-by: Judith Mendez <jm@...com>
> ---
> Changes since v1 RESEND:
> - split patch from series [0]
> - Add disable/enable calls without wrapper functions
> [0] https://lore.kernel.org/linux-omap/20241011173356.870883-1-jm@ti.com/
> 
> Tested on am335x BeagleBone Black
> ---
>   drivers/gpio/gpio-omap.c | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index 76d5d87e9681e..137aabada26f9 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -711,6 +711,28 @@ static void omap_gpio_unmask_irq(struct irq_data *d)
>   	raw_spin_unlock_irqrestore(&bank->lock, flags);
>   }
>   
> +static void omap_gpio_disable_irq(struct irq_data *d)
> +{
> +	struct gpio_bank *bank = omap_irq_data_get_bank(d);
> +	unsigned int offset = d->hwirq;
> +	unsigned long flags;
> +
> +	raw_spin_lock_irqsave(&bank->lock, flags);
> +	omap_set_gpio_irqenable(bank, offset, 0);
> +	raw_spin_unlock_irqrestore(&bank->lock, flags);
> +}
> +
> +static void omap_gpio_enable_irq(struct irq_data *d)
> +{
> +	struct gpio_bank *bank = omap_irq_data_get_bank(d);
> +	unsigned int offset = d->hwirq;
> +	unsigned long flags;
> +
> +	raw_spin_lock_irqsave(&bank->lock, flags);
> +	omap_set_gpio_irqenable(bank, offset, 1);
> +	raw_spin_unlock_irqrestore(&bank->lock, flags);
> +}
> +
>   static void omap_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
>   {
>   	struct gpio_bank *bank = omap_irq_data_get_bank(d);
> @@ -723,6 +745,8 @@ static const struct irq_chip omap_gpio_irq_chip = {
>   	.irq_shutdown = omap_gpio_irq_shutdown,
>   	.irq_mask = omap_gpio_mask_irq,
>   	.irq_unmask = omap_gpio_unmask_irq,
> +	.irq_disable = omap_gpio_disable_irq,
> +	.irq_enable = omap_gpio_enable_irq,
>   	.irq_set_type = omap_gpio_irq_type,
>   	.irq_set_wake = omap_gpio_wake_enable,
>   	.irq_bus_lock = omap_gpio_irq_bus_lock,
> @@ -737,6 +761,8 @@ static const struct irq_chip omap_gpio_irq_chip_nowake = {
>   	.irq_shutdown = omap_gpio_irq_shutdown,
>   	.irq_mask = omap_gpio_mask_irq,
>   	.irq_unmask = omap_gpio_unmask_irq,
> +	.irq_disable = omap_gpio_disable_irq,
> +	.irq_enable = omap_gpio_enable_irq,
>   	.irq_set_type = omap_gpio_irq_type,
>   	.irq_bus_lock = omap_gpio_irq_bus_lock,
>   	.irq_bus_sync_unlock = gpio_irq_bus_sync_unlock,