linux-kernel - Re: [PATCH] HID: hid-goodix: Improve handling of HID feature reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyLIZXnH1h4snkuB@google.com>
Date: Wed, 30 Oct 2024 16:59:33 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Charles Wang <charles.goodix@...il.com>
Cc: hbarnor@...omium.org, jikos@...nel.org, bentiss@...nel.org,
	dianders@...omium.org, dan.carpenter@...aro.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: hid-goodix: Improve handling of HID feature reports

Hi Charles,

On Wed, Oct 23, 2024 at 04:27:03PM +0800, Charles Wang wrote:
> 1) Align with the i2c-hid driver by returning 0 instead of -EINVAL when
> an empty response is received, ensuring that userspace programs utilizing
> the hidraw node receive consistent return values.
> 
> 2) Implement the hid get/set feature report function using a separate
> address, rather than sharing an address with coordinate reporting, to
> prevent feature events from being overwritten by coordinate events.

These are 2 independent changes, they should be 2 separate patches. 

Thanks.

-- 
Dmitry