Message-ID:
 <PAXPR04MB9448C598AEB4F9356D33DC3AF4542@PAXPR04MB9448.eurprd04.prod.outlook.com>
Date: Wed, 30 Oct 2024 06:33:30 +0000
From: Sandor Yu <sandor.yu@....com>
To: Martin Kepplinger-Novakovic <martink@...teo.de>,
	"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
	"andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>, Laurent Pinchart
	<laurent.pinchart@...asonboard.com>, "jonas@...boo.se" <jonas@...boo.se>,
	"jernej.skrabec@...il.com" <jernej.skrabec@...il.com>, "airlied@...il.com"
	<airlied@...il.com>, "daniel@...ll.ch" <daniel@...ll.ch>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>,
	"vkoul@...nel.org" <vkoul@...nel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, "mripard@...nel.org" <mripard@...nel.org>
CC: "kernel@...gutronix.de" <kernel@...gutronix.de>, dl-linux-imx
	<linux-imx@....com>, Oliver Brown <oliver.brown@....com>,
	"alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
	"sam@...nborg.org" <sam@...nborg.org>
Subject: RE: [EXT] Re: [PATCH v16 0/8] Initial support Cadence
 MHDP8501(HDMI/DP) for i.MX8MQ

> 
> Am Dienstag, dem 02.07.2024 um 20:22 +0800 schrieb Sandor Yu:
> > This patchset sits on top
> > Dmitry's 'make use of the HDMI connector infrastructure' patchset
> > ([2]).
> >
> > The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge
> > driver and Cadence HDP-TX PHY(HDMI/DP) driver for Freescale i.MX8MQ.
> >
> > The patch set compose of DRM bridge drivers and PHY driver.
> >
> > Both of them need by patch #1 and #2 to pass build.
> >
> > DRM bridges driver patches:
> >   #1: drm: bridge: Cadence: Creat mhdp helper driver
> >   #2: phy: Add HDMI configuration options
> >   #3: dt-bindings: display: bridge: Add Cadence MHDP8501
> >   #4: drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver
> >
> > PHY driver patches:
> >   #1: drm: bridge: Cadence: Creat mhdp helper driver
> >   #2: phy: Add HDMI configuration options
> >   #5: dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY
> >   #6: phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for
> > i.MX8MQ
> >
> > i.MX8M/TQMa8Mx DT patches:
> >   #7: Add DT nodes for DCSS/HDMI pipeline
> >   #8: Enable HDMI for TQMa8Mx/MBa8Mx
> >
> > [2]
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.freedesktop.org%2Fseries%2F130888%2F&data=05%7C02%7CSandor.
> yu%40
> >
> nxp.com%7C1de0bcd26e364c67de8908dcf7efc1de%7C686ea1d3bc2b4c6fa9
> 2cd99c5
> >
> c301635%7C0%7C0%7C638657856327615887%7CUnknown%7CTWFpbGZsb
> 3d8eyJWIjoiM
> >
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7
> C%7C%7C
> >
> &sdata=8cvug9CMLQNCPpOm8eFw3uaszeUN7hZijPSBP2IX17U%3D&reserve
> d=0
> >
> > v15->v16:
> > Patch #2:
> > - Remove pixel_clk_rate, bpc and color_space fields from struct
> >   phy_configure_opts_hdmi, they were replaced by
> >   unsigned long long tmds_char_rate.
> > - Remove r-b and a-c tags because this patch have important change.
> > Patch #4:
> > - Add DRM_BRIDGE_OP_HDMI flags for HDMI driver,
> > - Introduce the hdmi info frame helper functions,
> >   added hdmi_clear_infoframe(), hdmi_write_infoframe() and
> >   hdmi_tmds_char_rate_valid() according Dmitry's patch
> >   'make use of the HDMI connector infrastructure' patchset ([2]).
> > - mode_fixup() is replaced by atomic_check().
> > - Fix video mode 4Kp30 did not work on some displays that support
> >   LTE_340Mcsc_scramble.
> > - updated for tmds_char_rate added in patch #2.
> > Patch #6:
> > - updated for tmds_char_rate added in patch #2.
> >
> > v14->v15:
> > Patch #6 + #7:
> > -  Merged PHY driver into a single combo PHY driver Patch #7 + #8:
> > - Add DT patches for a running HDMI setup
> >
> > v13->v14:
> > Patch #4:
> > - Rebase to next-20240219, replace get_edid function by edid_read
> >   function as commits d807ad80d811b ("drm/bridge: add ->edid_read
> >   hook and drm_bridge_edid_read()") and 27b8f91c08d99 ("drm/bridge:
> >   remove ->get_edid callback") had change the API.
> >
> > v12->v13:
> > Patch #4:
> > - Explicitly include linux/platform_device.h for cdns-mhdp8501-core.c
> > - Fix build warning
> > - Order bit bpc and color_space in descending shit.
> > Patch #7:
> > - Fix build warning
> >
> > v11->v12:
> > Patch #1:
> > - Move status initialize out of mbox_mutex.
> > - Reorder API functions in alphabetical.
> > - Add notes for malibox access functions.
> > - Add year 2024 to copyright.
> > Patch #4:
> > - Replace DRM_INFO with dev_info or dev_warn.
> > - Replace DRM_ERROR with dev_err.
> > - Return ret when cdns_mhdp_dpcd_read failed in function
> > cdns_dp_aux_transferi().
> > - Remove unused parmeter in function cdns_dp_get_msa_misc
> >   and use two separate variables for color space and bpc.
> > - Add year 2024 to copyright.
> > Patch #6:
> > - Return error code to replace -1 for function wait_for_ack().
> > - Set cdns_phy->power_up = false in phy_power_down function.
> > - Remove "RATE_8_1 = 810000", it is not used in driver.
> > - Add year 2024 to copyright.
> > Patch #7:
> > - Adjust clk disable order.
> > - Return error code to replace -1 for function wait_for_ack().
> > - Use bool for variable pclk_in.
> > - Add year 2024 to copyright.
> >
> > v10->v11:
> > - rewrite cdns_mhdp_set_firmware_active() in mhdp8546 core driver, use
> > cdns_mhdp_mailbox_send() to replace cdns_mhdp_mailbox_write() same
> as
> > the other mailbox access functions.
> > - use static for cdns_mhdp_mailbox_write() and
> > cdns_mhdp_mailbox_read()
> > and remove them from EXPORT_SYMBOL_GPL().
> > - remove MODULE_ALIAS() from mhdp8501 driver.
> >
> > v9->v10:
> > - Create mhdp helper driver to replace macro functions, move all mhdp
> > mailbox access functions and common functions into the helper driver.
> > Patch #1:drm: bridge: Cadence: Creat mhdp helper driver it is totaly
> > different with v9.
> >
> > v8->v9:
> > - Remove compatible string "cdns,mhdp8501" that had removed
> >   from dt-bindings file in v8.
> > - Add Dmitry's R-b tag to patch #2
> > - Add Krzysztof's R-b tag to patch #3
> >
> > v7->v8:
> > MHDP8501 HDMI/DP:
> > - Correct DT node name to "display-bridge".
> > - Remove "cdns,mhdp8501" from mhdp8501 dt-binding doc.
> >
> > HDMI/DP PHY:
> > - Introduced functions `wait_for_ack` and `wait_for_ack_clear` to
> > handle
> >   waiting with acknowledgment bits set and cleared respectively.
> > - Use FIELD_PRE() to set bitfields for both HDMI and DP PHY.
> >
> > v6->v7:
> > MHDP8501 HDMI/DP:
> > - Combine HDMI and DP driver into one mhdp8501 driver.
> >   Use the connector type to load the corresponding functions.
> > - Remove connector init functions.
> > - Add <linux/hdmi.h> in phy_hdmi.h to reuse 'enum hdmi_colorspace'.
> >
> > HDMI/DP PHY:
> > - Lowercase hex values
> > - Fix parameters indent issue on some functions
> > - Replace 'udelay' with 'usleep_range'
> >
> > v5->v6:
> > HDMI/DP bridge driver
> > - 8501 is the part number of Cadence MHDP on i.MX8MQ.
> >   Use MHDP8501 to name hdmi/dp drivers and files.
> > - Add compatible "fsl,imx8mq-mhdp8501-dp" for i.MX8MQ DP driver
> > - Add compatible "fsl,imx8mq-mhdp8501-hdmi" for i.MX8MQ HDMI driver
> > - Combine HDMI and DP dt-bindings into one file cdns,mhdp8501.yaml
> > - Fix HDMI scrambling is not enable issue when driver working in
> > 4Kp60
> >   mode.
> > - Add HDMI/DP PHY API mailbox protect.
> >
> > HDMI/DP PHY driver:
> > - Rename DP and HDMI PHY files and move to folder phy/freescale/
> > - Remove properties num_lanes and link_rate from DP PHY driver.
> > - Combine HDMI and DP dt-bindings into one file fsl,imx8mq-dp-hdmi-
> > phy.yaml
> > - Update compatible string to "fsl,imx8mq-dp-phy".
> > - Update compatible string to "fsl,imx8mq-hdmi-phy".
> >
> > v4->v5:
> > - Drop "clk" suffix in clock name.
> > - Add output port property in the example of hdmi/dp.
> >
> > v3->v4:
> > dt-bindings:
> > - Correct dt-bindings coding style and address review comments.
> > - Add apb_clk description.
> > - Add output port for HDMI/DP connector
> > PHY:
> > - Alphabetically sorted in Kconfig and Makefile for DP and HDMI PHY
> > - Remove unused registers define from HDMI and DP PHY drivers.
> > - More description in phy_hdmi.h.
> > - Add apb_clk to HDMI and DP phy driver.
> > HDMI/DP:
> > - Use get_unaligned_le32() to replace hardcode type conversion
> >   in HDMI AVI infoframe data fill function.
> > - Add mailbox mutex lock in HDMI/DP driver for phy functions
> >   to reslove race conditions between HDMI/DP and PHY drivers.
> > - Add apb_clk to both HDMI and DP driver.
> > - Rename some function names and add prefix with "cdns_hdmi/cdns_dp".
> > - Remove bpc 12 and 16 optional that not supported.
> >
> > v2->v3:
> > Address comments for dt-bindings files.
> > - Correct dts-bindings file names
> >   Rename phy-cadence-hdptx-dp.yaml to cdns,mhdp-imx8mq-dp.yaml
> >   Rename phy-cadence-hdptx-hdmi.yaml to
> cdns,mhdp-imx8mq-hdmi.yaml
> > - Drop redundant words and descriptions.
> > - Correct hdmi/dp node name.
> >
> > v2 is a completely different version compared to v1.
> > Previous v1 can be available here [1].
> >
> > v1->v2:
> > - Reuse Cadence mailbox access functions from mhdp8546 instead of
> >   rockchip DP.
> > - Mailbox access functions be convert to marco functions
> >   that will be referenced by HDP-TX PHY(HDMI/DP) driver too.
> > - Plain bridge instead of component driver.
> > - Standalone Cadence HDP-TX PHY(HDMI/DP) driver.
> > - Audio driver are removed from the patch set, it will be add in
> > another
> >   patch set later.
> >
> > [1]
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.kernel.org%2Fproject%2Flinux-rockchip%2Fcover%2Fcover.159098288
> 1
> > .git.Sandor.yu%40nxp.com%2F&data=05%7C02%7CSandor.yu%40nxp.com%
> 7C1de0b
> >
> cd26e364c67de8908dcf7efc1de%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0
> > %7C638657856327659846%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> LjAwMDAiLCJQ
> >
> IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=jY
> pCSiHd
> > TJTBTxeb76u5Rm4O6MCi9SLIadz92ZONLmk%3D&reserved=0
> >
> > Alexander Stein (2):
> >   arm64: dts: imx8mq: Add DCSS + HDMI/DP display pipeline
> >   arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support
> >
> > Sandor Yu (6):
> >   drm: bridge: Cadence: Create mhdp helper driver
> >   phy: Add HDMI configuration options
> >   dt-bindings: display: bridge: Add Cadence MHDP8501
> >   drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver
> >   dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY
> >   phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ
> >
> >  .../display/bridge/cdns,mhdp8501.yaml         |  104 ++
> >  .../bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml  |   51 +
> >  .../dts/freescale/imx8mq-tqma8mq-mba8mx.dts   |   20 +
> >  arch/arm64/boot/dts/freescale/imx8mq.dtsi     |   68 +
> >  arch/arm64/boot/dts/freescale/mba8mx.dtsi     |   11 +
> >  drivers/gpu/drm/bridge/cadence/Kconfig        |   20 +
> >  drivers/gpu/drm/bridge/cadence/Makefile       |    3 +
> >  .../gpu/drm/bridge/cadence/cdns-mhdp-helper.c |  304 ++++
> >  .../drm/bridge/cadence/cdns-mhdp8501-core.c   |  330 ++++
> >  .../drm/bridge/cadence/cdns-mhdp8501-core.h   |  367 +++++
> >  .../gpu/drm/bridge/cadence/cdns-mhdp8501-dp.c |  700 +++++++++
> >  .../drm/bridge/cadence/cdns-mhdp8501-hdmi.c   |  595 ++++++++
> >  .../drm/bridge/cadence/cdns-mhdp8546-core.c   |  403 +----
> >  .../drm/bridge/cadence/cdns-mhdp8546-core.h   |   44 +-
> >  drivers/phy/freescale/Kconfig                 |   10 +
> >  drivers/phy/freescale/Makefile                |    1 +
> >  drivers/phy/freescale/phy-fsl-imx8mq-hdptx.c  | 1340
> > +++++++++++++++++
> >  include/drm/bridge/cdns-mhdp-helper.h         |   97 ++
> >  include/linux/phy/phy-hdmi.h                  |   20 +
> >  include/linux/phy/phy.h                       |    7 +-
> >  20 files changed, 4120 insertions(+), 375 deletions(-)  create mode
> > 100644
> > Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> >  create mode 100644
> Documentation/devicetree/bindings/phy/fsl,imx8mq-
> > dp-hdmi-phy.yaml
> >  create mode 100644
> drivers/gpu/drm/bridge/cadence/cdns-mhdp-helper.c
> >  create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8501-
> > core.c
> >  create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8501-
> > core.h
> >  create mode 100644
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8501-dp.c
> >  create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8501-
> > hdmi.c
> >  create mode 100644 drivers/phy/freescale/phy-fsl-imx8mq-hdptx.c
> >  create mode 100644 include/drm/bridge/cdns-mhdp-helper.h
> >  create mode 100644 include/linux/phy/phy-hdmi.h
> >
> 
> I ran this on top of a v6.11 kernel on imx8mq (type-c dp) and got -22 at the
> link-training command.
> 
> I'll try to test v18 later and can post my tree, but wanted to drop this here in
> case any bell rings already and so that you are aware that I want to test this.
> 
> thanks for keeping so patient with this,
> 
Here is the firmware version register dump in my board, Please check it in your board.
If the version is different.
You might need to update the firmware.

root@...8mqevk:~# /unit_tests/memtool -32 0x32c0001c 4
Reading 0x4 count starting at address 0x32C0001C
0x32C0001C:  000000CF 00000087 000000D3 00000050

B.R
Sandor

>                               martin

Powered by blists - more mailing lists