linux-kernel - Re: [PATCH] soc: Switch back to struct platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c7893f5186f0c6d64c063dc0a609ec8d6c8bcf1.camel@codeconstruct.com.au>
Date: Wed, 30 Oct 2024 10:53:09 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
	Arnd Bergmann
	 <arnd@...db.de>, Olof Johansson <olof@...om.net>
Cc: Joel Stanley <joel@....id.au>, Christophe Leroy
 <christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>, 
 Qiang Zhao <qiang.zhao@....com>, Hitomi Hasegawa
 <hasegawa-hitomi@...itsu.com>, Huisong Li <lihuisong@...wei.com>, Linus
 Walleij <linusw@...nel.org>, Imre Kaloz <kaloz@...nwrt.org>, Karol Gugala
 <kgugala@...micro.com>, Mateusz Holenko <mholenko@...micro.com>, Gabriel
 Somlo <gsomlo@...il.com>, Yinbo Zhu <zhuyinbo@...ngson.cn>, Matthias
 Brugger <matthias.bgg@...il.com>,  AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Conor Dooley
 <conor.dooley@...rochip.com>, Daire McNamara
 <daire.mcnamara@...rochip.com>, Krzysztof Kozlowski
 <krzysztof.kozlowski@...aro.org>, Bjorn Andersson <andersson@...nel.org>, 
 Konrad Dybcio <konradybcio@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Alim Akhtar <alim.akhtar@...sung.com>,  Thierry Reding
 <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>,
 Nishanth Menon <nm@...com>,  Santosh Shilimkar <ssantosh@...nel.org>,
 Michal Simek <michal.simek@....com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Duje Mihanović
 <duje.mihanovic@...le.hr>, Mark Brown <broonie@...nel.org>, David Wu
 <david.wu@...k-chips.com>, Jianqun Xu <jay.xu@...k-chips.com>, Jay
 Buddhabhatti <jay.buddhabhatti@....com>, Radhey Shyam Pandey
 <radhey.shyam.pandey@....com>,  Izhar Ameer Shaikh
 <izhar.ameer.shaikh@....com>, Naman Trivedi Manojbhai
 <naman.trivedimanojbhai@....com>,  linux-arm-kernel@...ts.infradead.org,
 soc@...ts.linux.dev,  linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org,  linuxppc-dev@...ts.ozlabs.org,
 loongarch@...ts.linux.dev,  linux-mediatek@...ts.infradead.org,
 linux-riscv@...ts.infradead.org,  linux-arm-msm@...r.kernel.org,
 linux-rockchip@...ts.infradead.org,  linux-samsung-soc@...r.kernel.org,
 linux-tegra@...r.kernel.org,  linux-pm@...r.kernel.org
Subject: Re: [PATCH] soc: Switch back to struct platform_driver::remove()

On Tue, 2024-10-29 at 08:48 +0100, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement
> for
> platform drivers.
> 
> Convert all platform drivers below drivers/soc to use .remove(), with
> the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is
> done
> by just changing the structure member name in the driver initializer.
> 
> On the way do a few whitespace changes to make indention consistent.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
> Hello,
> 
> I did a single patch for all of drivers/soc. While I usually prefer
> to
> do one logical change per patch, this seems to be overengineering
> here
> as the individual changes are really trivial and shouldn't be much in
> the way for stable backports.
> 
> There is no dedicated maintainer for all of drivers/soc, but I'd
> expect
> it to be ok to be picked up by the arm soc team.
> 
> This is based on today's next, if conflicts arise when you apply it
> at
> some later time and don't want to resolve them, feel free to just
> drop
> the changes to the conflicting files. I'll notice and followup at a
> later time then. Or ask me for a fixed resend.
> 
> Best regards
> Uwe
> 
>  drivers/soc/aspeed/aspeed-lpc-ctrl.c        | 2 +-
>  drivers/soc/aspeed/aspeed-lpc-snoop.c       | 2 +-
>  drivers/soc/aspeed/aspeed-p2a-ctrl.c        | 2 +-
>  drivers/soc/aspeed/aspeed-uart-routing.c    | 2 +-

Acked-by: Andrew Jeffery <andrew@...econstruct.com.au> # aspeed