linux-kernel - Re: [PATCH] selftest/hid: increase timeout to 10 min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4pfwh24gmu4ujb5iwjjo5oxh4mfja2ajtkrkbzbbshjkoz5wjx@ac4tfdc5twxe>
Date: Wed, 30 Oct 2024 09:00:08 +0100
From: Benjamin Tissoires <bentiss@...nel.org>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Yun Lu <luyun@...inos.cn>, jikos@...nel.org, shuah@...nel.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftest/hid: increase timeout to 10 min

On Oct 29 2024, Shuah Khan wrote:
> On 10/29/24 03:07, Yun Lu wrote:
> > If running hid testcases with command "./run_kselftest.sh -c hid",
> 
> NIT - When inestead of "If"
> > the following tests will take longer than the kselftest framework
> > timeout (now 200 seconds) to run and thus got terminated with TIMEOUT
> > error:
> > 
> >    hid-multitouch.sh - took about 6min41s
> >    hid-tablet.sh - took about 6min30s
> > 
> > Increase the timeout setting to 10 minutes to allow them have a chance
> > to finish.
> > 
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Yun Lu <luyun@...inos.cn>
> > ---
> >   tools/testing/selftests/hid/settings | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/hid/settings b/tools/testing/selftests/hid/settings
> > index b3cbfc521b10..dff0d947f9c2 100644
> > --- a/tools/testing/selftests/hid/settings
> > +++ b/tools/testing/selftests/hid/settings
> > @@ -1,3 +1,3 @@
> >   # HID tests can be long, so give a little bit more time
> >   # to them
> > -timeout=200
> > +timeout=600
> 
> Okay - maybe this test shouldn't be part of the default run if it needs
> 600 seconds to run?

Agree, but is it possible to be more granular?

FWIW, there are some tests that are quick in the hid subtree that should
probably be run regularly. For instance, the hid_bpf program is
interesting to be run when there are bpf changes, because it's relying
on the bpf architecture.

I think hid-core.sh, hid-mouse,sh and hid-keyboard.sh are fast enough
and should also be integrated in the default runs.

hid-multitouch, hid-wacom, hid-sony are definitely taking a lot of time,
so they should probbaly be run only when there are changes in those
areas, i.e., not by default.

Cheers,
Benjamin

> 
> thanks,
> -- Shuah