linux-kernel - Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable cci_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5003f25-6a00-42f8-a130-5ce3c8761674@linaro.org>
Date: Wed, 30 Oct 2024 12:53:40 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, loic.poulain@...aro.org
Cc: rfoss@...nel.org, andi.shyti@...nel.org, linux-i2c@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable
 cci_clk_rate

On 10/29/24 04:09, Jiapeng Chong wrote:
> Variable ret is not effectively used, so delete it.

Variable ret is not deleted, the commit message is misleading.

> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

With the needed change to the commit message:

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>

--
Best wishes,
Vladimir