linux-kernel - 答复: [PATCH v2] usb: typec: qcom-pmic: init value of hdr_len/txbuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <KL1PR0601MB57733B7B2B6DE5CC57AF074AE6542@KL1PR0601MB5773.apcprd06.prod.outlook.com>
Date: Wed, 30 Oct 2024 10:35:41 +0000
From: Rex Nie <rex.nie@...uarmicro.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC: "bryan.odonoghue@...aro.org" <bryan.odonoghue@...aro.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Angus Chen
	<angus.chen@...uarmicro.com>
Subject:
 答复: [PATCH v2] usb: typec: qcom-pmic: init value of hdr_len/txbuf_len earlier

HI heikki,
	Thanks. I will send patch v3 soon.
BRs
Rex

> -----邮件原件-----
> 发件人: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> 发送时间: 2024年10月30日 16:39
> 收件人: Rex Nie <rex.nie@...uarmicro.com>
> 抄送: bryan.odonoghue@...aro.org; gregkh@...uxfoundation.org;
> linux-arm-msm@...r.kernel.org; linux-usb@...r.kernel.org;
> linux-kernel@...r.kernel.org; Angus Chen <angus.chen@...uarmicro.com>
> 主题: Re: [PATCH v2] usb: typec: qcom-pmic: init value of hdr_len/txbuf_len
> earlier
> 
> External Mail: This email originated from OUTSIDE of the organization!
> Do not click links, open attachments or provide ANY information unless you
> recognize the sender and know the content is safe.
> 
> 
> Hi,
> 
> On Wed, Oct 30, 2024 at 10:27:54AM +0800, Rex Nie wrote:
> > If the read of USB_PDPHY_RX_ACKNOWLEDGE_REG failed, then hdr_len and
> > txbuf_len are uninitialized. This commit stops to print uninitialized
> > value and misleading/false data.
> >
> > Signed-off-by: Rex Nie <rex.nie@...uarmicro.com>
> > ---
> 
> You need to include a changelog also for the patch itself here, after that "---"
> separator. This patch is also still missing the Fixes tag.
> 
> You can read more about how to send the patches from the documentation:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> 
> So please send v3 with those fixed. Don't forget to Cc the stable ml.:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#s
> elect-the-recipients-for-your-patch
> 
> thanks,
> 
> >  drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> > b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> > index 5b7f52b74a40..726423684bae 100644
> > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> > @@ -227,6 +227,10 @@
> qcom_pmic_typec_pdphy_pd_transmit_payload(struct
> > pmic_typec_pdphy *pmic_typec_pd
> >
> >       spin_lock_irqsave(&pmic_typec_pdphy->lock, flags);
> >
> > +     hdr_len = sizeof(msg->header);
> > +     txbuf_len = pd_header_cnt_le(msg->header) * 4;
> > +     txsize_len = hdr_len + txbuf_len - 1;
> > +
> >       ret = regmap_read(pmic_typec_pdphy->regmap,
> >                         pmic_typec_pdphy->base +
> USB_PDPHY_RX_ACKNOWLEDGE_REG,
> >                         &val);
> > @@ -244,10 +248,6 @@
> qcom_pmic_typec_pdphy_pd_transmit_payload(struct pmic_typec_pdphy
> *pmic_typec_pd
> >       if (ret)
> >               goto done;
> >
> > -     hdr_len = sizeof(msg->header);
> > -     txbuf_len = pd_header_cnt_le(msg->header) * 4;
> > -     txsize_len = hdr_len + txbuf_len - 1;
> > -
> >       /* Write message header sizeof(u16) to
> USB_PDPHY_TX_BUFFER_HDR_REG */
> >       ret = regmap_bulk_write(pmic_typec_pdphy->regmap,
> >                               pmic_typec_pdphy->base +
> > USB_PDPHY_TX_BUFFER_HDR_REG,
> > --
> > 2.17.1
> 
> --
> heikki