linux-kernel - Re: [PATCH bpf-next v4 0/9] net: ip: add drop reasons to input route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029170341.1b351225@kernel.org>
Date: Tue, 29 Oct 2024 17:03:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: pabeni@...hat.com, davem@...emloft.net, edumazet@...gle.com,
 dsahern@...nel.org, pablo@...filter.org, kadlec@...filter.org,
 roopa@...dia.com, razor@...ckwall.org, gnault@...hat.com,
 bigeasy@...utronix.de, idosch@...dia.com, ast@...nel.org,
 dongml2@...natelecom.cn, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
 coreteam@...filter.org, bridge@...ts.linux.dev, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v4 0/9] net: ip: add drop reasons to input
 route

On Thu, 24 Oct 2024 17:33:39 +0800 Menglong Dong wrote:
> In this series, we mainly add some skb drop reasons to the input path of
> ip routing, and we make the following functions return drop reasons:
> 
>   fib_validate_source()
>   ip_route_input_mc()
>   ip_mc_validate_source()
>   ip_route_input_slow()
>   ip_route_input_rcu()
>   ip_route_input_noref()
>   ip_route_input()
>   ip_mkroute_input()
>   __mkroute_input()
>   ip_route_use_hint()
> 
> And following new skb drop reasons are added:
> 
>   SKB_DROP_REASON_IP_LOCAL_SOURCE
>   SKB_DROP_REASON_IP_INVALID_SOURCE
>   SKB_DROP_REASON_IP_LOCALNET
>   SKB_DROP_REASON_IP_INVALID_DEST

We're "a bit" behind on patches after my vacation, so no real review
here, but please repost with net-next in the subject. The test
automation trusts the tree designation and bpf-next is no longer
based on net-next. So this doesn't apply.
-- 
pw-bot: cr