linux-kernel - Re: [PATCH] spi: atmel-quadspi: Create `atmel_qspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202410300915.VPL8EQQu-lkp@intel.com>
Date: Wed, 30 Oct 2024 09:20:00 +0800
From: kernel test robot <lkp@...el.com>
To: Csókás, Bence <csokas.bence@...lan.hu>,
	linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
	Csókás, Bence <csokas.bence@...lan.hu>,
	Tudor Ambarus <tudor.ambarus@...aro.org>,
	Varshini Rajendran <varshini.rajendran@...rochip.com>,
	Mark Brown <broonie@...nel.org>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>
Subject: Re: [PATCH] spi: atmel-quadspi: Create `atmel_qspi_ops` to support
 newer SoC families

Hi Bence,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on soc/for-next linus/master v6.12-rc5 next-20241029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cs-k-s-Bence/spi-atmel-quadspi-Create-atmel_qspi_ops-to-support-newer-SoC-families/20241029-210231
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20241029125843.2384307-1-csokas.bence%40prolan.hu
patch subject: [PATCH] spi: atmel-quadspi: Create `atmel_qspi_ops` to support newer SoC families
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20241030/202410300915.VPL8EQQu-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241030/202410300915.VPL8EQQu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410300915.VPL8EQQu-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/spi/atmel-quadspi.c: In function 'atmel_qspi_transfer':
>> drivers/spi/atmel-quadspi.c:446:68: error: 'struct spi_device' has no member named 'master'
     446 |         struct atmel_qspi *aq = spi_controller_get_devdata(mem->spi->master);
         |                                                                    ^~


vim +446 drivers/spi/atmel-quadspi.c

   442	
   443	static int atmel_qspi_transfer(struct spi_mem *mem,
   444				       const struct spi_mem_op *op, u32 offset)
   445	{
 > 446		struct atmel_qspi *aq = spi_controller_get_devdata(mem->spi->master);
   447	
   448		/* Skip to the final steps if there is no data */
   449		if (!op->data.nbytes)
   450			return atmel_qspi_wait_for_completion(aq,
   451							      QSPI_SR_CMD_COMPLETED);
   452	
   453		/* Dummy read of QSPI_IFR to synchronize APB and AHB accesses */
   454		(void)atmel_qspi_read(aq, QSPI_IFR);
   455	
   456		/* Send/Receive data */
   457		if (op->data.dir == SPI_MEM_DATA_IN)
   458			memcpy_fromio(op->data.buf.in, aq->mem + offset,
   459				      op->data.nbytes);
   460		else
   461			memcpy_toio(aq->mem + offset, op->data.buf.out,
   462				    op->data.nbytes);
   463	
   464		/* Release the chip-select */
   465		atmel_qspi_write(QSPI_CR_LASTXFER, aq, QSPI_CR);
   466	
   467		return atmel_qspi_wait_for_completion(aq, QSPI_SR_CMD_COMPLETED);
   468	}
   469	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki