[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241030113946.229361-1-james.clark@linaro.org>
Date: Wed, 30 Oct 2024 11:39:43 +0000
From: James Clark <james.clark@...aro.org>
To: linux-perf-users@...r.kernel.org,
acme@...nel.org,
namhyung@...nel.org,
irogers@...gle.com,
tim.c.chen@...ux.intel.com
Cc: James Clark <james.clark@...aro.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
"Liang, Kan" <kan.liang@...ux.intel.com>,
Yicong Yang <yangyicong@...ilicon.com>,
linux-kernel@...r.kernel.org
Subject: [PATCH v2 0/2] perf stat: Fix trailing comma when there is no metric unit
The first commit is failing on Arm and I think the fix should stop more
trailing comma issues which keep happening.
The second one I just noticed when looking at it. I don't feel strongly
about it so not sure if we should do it or not, but seems like the empty
metric-units exclusion from the JSON should be consistent if we're going
to have it at all.
Changes since v1:
* Don't skip printing when the metric-unit string is empty but pass
NULL instead of an empty string.
James Clark (2):
perf stat: Fix trailing comma when there is no metric unit
perf stat: Also hide metric-units from JSON when event didn't run
.../tests/shell/lib/perf_json_output_lint.py | 14 +-
tools/perf/util/stat-display.c | 182 ++++++++++--------
2 files changed, 107 insertions(+), 89 deletions(-)
--
2.34.1
Powered by blists - more mailing lists