linux-kernel - Re: [PATCH V4 3/4] pmdomain: core: Fix debugfs node creation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1c14b44-c11a-9855-45a1-9a30fe40c01f@quicinc.com>
Date: Wed, 30 Oct 2024 18:22:15 +0530
From: Sibi Sankar <quic_sibis@...cinc.com>
To: Johan Hovold <johan@...nel.org>
CC: <sudeep.holla@....com>, <cristian.marussi@....com>,
        <ulf.hansson@...aro.org>, <jassisinghbrar@...il.com>,
        <dmitry.baryshkov@...aro.org>, <linux-kernel@...r.kernel.org>,
        <arm-scmi@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>, <konradybcio@...nel.org>,
        <linux-pm@...r.kernel.org>, <tstrudel@...gle.com>, <rafael@...nel.org>,
        Johan
 Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH V4 3/4] pmdomain: core: Fix debugfs node creation failure



On 10/25/24 19:41, Johan Hovold wrote:
> On Fri, Oct 25, 2024 at 07:36:16PM +0530, Sibi Sankar wrote:
>> On 10/25/24 19:23, Johan Hovold wrote:
> 
>>> Also seems to do the trick:
>>>
>>> Tested-by: Johan Hovold <johan+linaro@...nel.org>
>>>
>>> But perhaps you could consider starting enumerating the duplicate
>>> domains from 2 (or 1) instead of 0?:
>>>
>>> NCC_1                           on                              0
>>> NCC_0                           on                              0
>>> NCC                             on                              0
>>
>> We are just trying to make sure node names are unique and
>> can't ensure the pd-name correctness since ida starts its
>> number generation from 0 and I didn't want to shape the
>> fix just to cater to our specific case. The firmware fix
>> will be in charge of ensuring pd-name correctness.
> 
> Ah, it's a global number space? I didn't really look at the
> implementation...

Thanks for testing out the patch. Yes it was a global number
space but we are changing the implementation again in the next
re-spin. Please try that out instead.

-Sibi

> 
> Johan