linux-kernel - RE: [PATCH] clk: starfive: jh7110-pll: Mark the probe function as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <NTZPR01MB095605A72E938ECBE381F4E69F542@NTZPR01MB0956.CHNPR01.prod.partner.outlook.cn>
Date: Wed, 30 Oct 2024 01:33:02 +0000
From: Xingyu Wu <xingyu.wu@...rfivetech.com>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>, Emil Renner Berthing
	<kernel@...il.dk>, Hal Feng <hal.feng@...rfivetech.com>, Michael Turquette
	<mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
CC: "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] clk: starfive: jh7110-pll: Mark the probe function as
 __init

On 29/10/2024 11:28, Changhuang Liang wrote:
> Subject: [PATCH] clk: starfive: jh7110-pll: Mark the probe function as __init
> 
> Mark the jh7110_pll_probe function as __init.
> 
> There's no need to support hotplugging in the jh7110-pll driver. We use
> builtin_platform_driver_probe, the probe function will only be called at startup.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> ---
>  drivers/clk/starfive/clk-starfive-jh7110-pll.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/starfive/clk-starfive-jh7110-pll.c b/drivers/clk/starfive/clk-
> starfive-jh7110-pll.c
> index 3598390e8fd0..56dc58a04f8a 100644
> --- a/drivers/clk/starfive/clk-starfive-jh7110-pll.c
> +++ b/drivers/clk/starfive/clk-starfive-jh7110-pll.c
> @@ -453,7 +453,7 @@ static struct clk_hw *jh7110_pll_get(struct
> of_phandle_args *clkspec, void *data
>  	return ERR_PTR(-EINVAL);
>  }
> 
> -static int jh7110_pll_probe(struct platform_device *pdev)
> +static int __init jh7110_pll_probe(struct platform_device *pdev)
>  {
>  	struct jh7110_pll_priv *priv;
>  	unsigned int idx;
> --

Reviewed-by: Xingyu Wu <xingyu.wu@...rfivetech.com>