linux-kernel - Re: [PATCH v3 1/2] KVM: x86/mmu: Track TDP MMU NX huge pages separately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyJBwQNRCFBTLQgx@google.com>
Date: Wed, 30 Oct 2024 07:25:05 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Vipin Sharma <vipinsh@...gle.com>
Cc: pbonzini@...hat.com, dmatlack@...gle.com, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] KVM: x86/mmu: Track TDP MMU NX huge pages separately

On Wed, Oct 30, 2024, Sean Christopherson wrote:
> On Fri, Sep 06, 2024, Vipin Sharma wrote:
> > +	struct list_head tdp_mmu_possible_nx_huge_pages;
> > +	u64 tdp_mmu_nr_possible_nx_huge_pages;
> 
> These obviously come in a pair, and must be passed around as such.  To make the
> relevant code easier on the eyes (long lines), and to avoid passing a mismatched
> pair, add a parent structure.
> 
> E.g.
> 
>   struct kvm_possible_nx_huge_pages {
> 	struct list_head list;

Actually, I vote for s/list/pages, as that makes the usage in code is more intuitive.

> 	u64 nr_pages;
>   }