linux-kernel - Re: [PATCH 4/5] mtd: rawnand: davinci: Add clock resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1aab934c-d28e-4ee8-a857-ffc2ef739488@kernel.org>
Date: Wed, 30 Oct 2024 15:26:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bastien Curutchet <bastien.curutchet@...tlin.com>,
 Santosh Shilimkar <ssantosh@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>
Cc: linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Herve Codina <herve.codina@...tlin.com>,
 Christopher Cordahi <christophercordahi@...ometrics.ca>
Subject: Re: [PATCH 4/5] mtd: rawnand: davinci: Add clock resource

On 30/10/2024 13:20, Bastien Curutchet wrote:
> Hi Krzysztof,
> 
> On 10/30/24 12:17 PM, Krzysztof Kozlowski wrote:
>> On 30/10/2024 11:47, Bastien Curutchet wrote:
>>> NAND controller has a reference clock but the driver doesn't use it.
>>>
>>> Add a struct clock in the struct davinci_nand_info so it can be used
>>> to compute timings.
>>>
>>> Signed-off-by: Bastien Curutchet <bastien.curutchet@...tlin.com>
>>> ---
>>>   drivers/mtd/nand/raw/davinci_nand.c | 9 +++++++++
>>
>> Where are the bindings?
>>
> 
> The NAND controller bindings are in 
> Documentation/devicetree/bindings/mtd/davinci-nand.txt but this clock is 
> defined in the AEMIF bindings in 
> Documentation/devicetree/bindings/memory-controllers/ti-aemif.txt

Mention this in commit msg so you get one reviewer question less...

Best regards,
Krzysztof