linux-kernel - Re: [RFC PATCH v4 4/4] tracing: Add might_fault() check in __DO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91b9202c-6124-44ec-9d44-4556fa21dd41@efficios.com>
Date: Wed, 30 Oct 2024 10:42:43 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Jordan Rife <jrife@...gle.com>
Cc: acme@...nel.org, alexander.shishkin@...ux.intel.com,
 andrii.nakryiko@...il.com, ast@...nel.org, bpf@...r.kernel.org,
 joel@...lfernandes.org, linux-kernel@...r.kernel.org, mark.rutland@....com,
 mhiramat@...nel.org, mingo@...hat.com, mjeanson@...icios.com,
 namhyung@...nel.org, paulmck@...nel.org, peterz@...radead.org,
 rostedt@...dmis.org, tglx@...utronix.de, yhs@...com
Subject: Re: [RFC PATCH v4 4/4] tracing: Add might_fault() check in
 __DO_TRACE() for syscall

On 2024-10-28 20:28, Jordan Rife wrote:
>> I can test this later today. Considering there needs to be a fix on
>> the BPF side to fully resolve the use-after-free issue reported by
>> syzbot, I may combine your v4 patch with the bandaid fix which chains
>> call_rcu->call_rcu_tasks_trace I made earlier while running the
>> reproducer locally.
> 
> Testing this way, the series LGTM. Here's what I did starting from
> linux-next tag next-20241028.
[...]
> Tested-by: Jordan Rife <jrife@...gle.com>
> 

Thanks! I'll add your tested-by tags and send a v5 non-RFC.

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com