linux-kernel - [PATCH v2 01/15] iio: light: ltr390: simplify code in write_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241031-iio-fix-write-event-config-signature-v2-1-2bcacbb517a2@baylibre.com>
Date: Thu, 31 Oct 2024 16:26:56 +0100
From: Julien Stephan <jstephan@...libre.com>
To: Mudit Sharma <muditsharma.info@...il.com>, 
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, 
 Anshul Dalal <anshulusr@...il.com>, 
 Javier Carrasco <javier.carrasco.cruz@...il.com>, 
 Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>, 
 Michael Hennerich <Michael.Hennerich@...log.com>, 
 Cosmin Tanislav <cosmin.tanislav@...log.com>, 
 Ramona Gradinariu <ramona.gradinariu@...log.com>, 
 Antoniu Miclaus <antoniu.miclaus@...log.com>, 
 Dan Robertson <dan@...obertson.com>, 
 Marcelo Schmitt <marcelo.schmitt@...log.com>, 
 Matteo Martelli <matteomartelli3@...il.com>, 
 Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>, 
 Michal Simek <michal.simek@....com>, 
 Mariel Tinaco <Mariel.Tinaco@...log.com>, 
 Jagath Jog J <jagathjog1996@...il.com>, 
 Lorenzo Bianconi <lorenzo@...nel.org>, 
 Subhajit Ghosh <subhajit.ghosh@...aklogic.com>, 
 Kevin Tsai <ktsai@...ellamicro.com>, 
 Linus Walleij <linus.walleij@...aro.org>, 
 Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, chrome-platform@...ts.linux.dev, 
 Julien Stephan <jstephan@...libre.com>
Subject: [PATCH v2 01/15] iio: light: ltr390: simplify code in
 write_event_config callback

iio_ev_state_store is actually using kstrtobool to check user
input, then gives the converted boolean value to the write_event_config
callback.

Remove useless code in write_event_config callback.

Signed-off-by: Julien Stephan <jstephan@...libre.com>
---
 drivers/iio/light/ltr390.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/iio/light/ltr390.c b/drivers/iio/light/ltr390.c
index 8e0a3fc3d923a6f65d2a629c87e7bfd35d82a507..3bdffb6360bcbaab4df1a2d39c8ea3813b5d6bd3 100644
--- a/drivers/iio/light/ltr390.c
+++ b/drivers/iio/light/ltr390.c
@@ -558,10 +558,7 @@ static int ltr390_write_event_config(struct iio_dev *indio_dev,
 	struct ltr390_data *data = iio_priv(indio_dev);
 	int ret;
 
-	if (state != 1  && state != 0)
-		return -EINVAL;
-
-	if (state == 0)
+	if (!state)
 		return regmap_clear_bits(data->regmap, LTR390_INT_CFG, LTR390_LS_INT_EN);
 
 	guard(mutex)(&data->lock);

-- 
2.47.0