linux-kernel - [PATCH v2 05/15] iio: proximity: sx9500: simplify code in write_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241031-iio-fix-write-event-config-signature-v2-5-2bcacbb517a2@baylibre.com>
Date: Thu, 31 Oct 2024 16:27:00 +0100
From: Julien Stephan <jstephan@...libre.com>
To: Mudit Sharma <muditsharma.info@...il.com>, 
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, 
 Anshul Dalal <anshulusr@...il.com>, 
 Javier Carrasco <javier.carrasco.cruz@...il.com>, 
 Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>, 
 Michael Hennerich <Michael.Hennerich@...log.com>, 
 Cosmin Tanislav <cosmin.tanislav@...log.com>, 
 Ramona Gradinariu <ramona.gradinariu@...log.com>, 
 Antoniu Miclaus <antoniu.miclaus@...log.com>, 
 Dan Robertson <dan@...obertson.com>, 
 Marcelo Schmitt <marcelo.schmitt@...log.com>, 
 Matteo Martelli <matteomartelli3@...il.com>, 
 Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>, 
 Michal Simek <michal.simek@....com>, 
 Mariel Tinaco <Mariel.Tinaco@...log.com>, 
 Jagath Jog J <jagathjog1996@...il.com>, 
 Lorenzo Bianconi <lorenzo@...nel.org>, 
 Subhajit Ghosh <subhajit.ghosh@...aklogic.com>, 
 Kevin Tsai <ktsai@...ellamicro.com>, 
 Linus Walleij <linus.walleij@...aro.org>, 
 Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, chrome-platform@...ts.linux.dev, 
 Julien Stephan <jstephan@...libre.com>
Subject: [PATCH v2 05/15] iio: proximity: sx9500: simplify code in
 write_event_config callback

iio_ev_state_store is actually using kstrtobool to check user
input, then gives the converted boolean value to the write_event_config
callback.

Remove useless code in write_event_config callback.

Signed-off-by: Julien Stephan <jstephan@...libre.com>
---
 drivers/iio/proximity/sx9500.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c
index 3f4eace05cfc6a4679fe82854dc059aa4a710d6d..e3da709424d5b2bd4e746df7adc4a4969e62f2a6 100644
--- a/drivers/iio/proximity/sx9500.c
+++ b/drivers/iio/proximity/sx9500.c
@@ -551,7 +551,7 @@ static int sx9500_write_event_config(struct iio_dev *indio_dev,
 
 	mutex_lock(&data->mutex);
 
-	if (state == 1) {
+	if (state) {
 		ret = sx9500_inc_chan_users(data, chan->channel);
 		if (ret < 0)
 			goto out_unlock;
@@ -571,7 +571,7 @@ static int sx9500_write_event_config(struct iio_dev *indio_dev,
 	goto out_unlock;
 
 out_undo_chan:
-	if (state == 1)
+	if (state)
 		sx9500_dec_chan_users(data, chan->channel);
 	else
 		sx9500_inc_chan_users(data, chan->channel);

-- 
2.47.0