linux-kernel - Re: [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJprsF7Wgb3zv1r9ZB4ngec0zPNeMjWOGkQDO63G3G9WYWQ@mail.gmail.com>
Date: Thu, 31 Oct 2024 17:45:14 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Krishna Kurapati <quic_kriskura@...cinc.com>, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support
 SAR2130P platform

On Thu, 31 Oct 2024 at 10:13, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Wed, Oct 30, 2024 at 01:50:54PM +0200, Dmitry Baryshkov wrote:
> > Extend the patterns in qcom-soc.yaml to support Qualcomm SAR2130P
> > platform.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > ---
> >  Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
>
> This should be squashed with next patch, adding SAR2130P. It's logically
> one change: you bring bindings for SA2130P.
>
>
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > index d0751a572af39eecbbd2f8323a6c3c94b3fdeeac..1add7267f541a24e82e0cec62af6f0c839aca267 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > @@ -23,7 +23,7 @@ description: |
> >  select:
> >    properties:
> >      compatible:
> > -      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+.*$"
> > +      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+.*$"
>
> Instead:
> s/sa/sar?/

I'd prefer not to do this. I think the patterns are complex enough, so
I've redesigned them a bit.
I'll send a proposed patchset later today.

>
>
> >    required:
> >      - compatible
> >
> > @@ -31,7 +31,7 @@ properties:
> >    compatible:
> >      oneOf:
> >        # Preferred naming style for compatibles of SoC components:
> > -      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+(pro)?-.*$"
> > +      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$"
>
> This breaks patterns. p|pro should stay as before. 8775p is below:
>
> >        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
>
> so this pattern could cover your sar, e.g. split:
> "^qcom,sc8[0-9]+[a-z][a-z]-.*$"
> "^qcom,sar?[0-9]+[a-z]-.*$"
>
> Best regards,
> Krzysztof
>


-- 
With best wishes
Dmitry