[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241031014743.2313121-1-quzicheng@huawei.com>
Date: Thu, 31 Oct 2024 01:47:43 +0000
From: Zicheng Qu <quzicheng@...wei.com>
To: <mazziesaccount@...il.com>, <jic23@...nel.org>, <lars@...afoo.de>,
<linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <tanghui20@...wei.com>, <zhangqiao22@...wei.com>,
<judy.chenhui@...wei.com>, <quzicheng@...wei.com>
Subject: [PATCH] iio: fix memory leak for iio_gts_build_avail_scale_table()
In iio_gts_build_avail_scale_table(), the memory allocated for
per_time_gains is freed using kfree(per_time_gains) before return 0.
However, the type per_time_gains is 'int **', and the memory allocated
for its inner elements is not being freed, leading to a memory leak.
Cc: stable@...r.kernel.org # v6.6+
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
Signed-off-by: Zicheng Qu <quzicheng@...wei.com>
---
drivers/iio/industrialio-gts-helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrialio-gts-helper.c
index 59d7615c0f56..f2450b2e740d 100644
--- a/drivers/iio/industrialio-gts-helper.c
+++ b/drivers/iio/industrialio-gts-helper.c
@@ -307,6 +307,8 @@ static int iio_gts_build_avail_scale_table(struct iio_gts *gts)
if (ret)
goto err_free_out;
+ for (j = 0; j < gts->num_itime; j++)
+ kfree(per_time_gains[i]);
kfree(per_time_gains);
gts->per_time_avail_scale_tables = per_time_scales;
--
2.34.1
Powered by blists - more mailing lists