| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<SN6PR02MB4157B87089C2A561146F0CE7D4552@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Thu, 31 Oct 2024 02:03:53 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>, "K. Y. Srinivasan"
<kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu
<wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, Anna-Maria
Behnsen <anna-maria@...utronix.de>, Thomas Gleixner <tglx@...utronix.de>,
Geert Uytterhoeven <geert@...ux-m68k.org>, Marcel Holtmann
<marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, Luiz Augusto
von Dentz <luiz.dentz@...il.com>, "linux-bluetooth@...r.kernel.org"
<linux-bluetooth@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, Praveen Kumar
<kumarpraveen@...ux.microsoft.com>, Naman Jain <namjain@...ux.microsoft.com>
Subject: RE: [PATCH v3 2/2] drivers: hv: Convert open-coded timeouts to
secs_to_jiffies()
From: Easwar Hariharan <eahariha@...ux.microsoft.com> Sent: Wednesday, October 30, 2024 10:48 AM
>
> We have several places where timeouts are open-coded as N (seconds) * HZ,
> but best practice is to use the utility functions from jiffies.h. Convert
> the timeouts to be compliant. This doesn't fix any bugs, it's a simple code
> improvement.
>
> TO: "K. Y. Srinivasan" <kys@...rosoft.com>
> TO: Haiyang Zhang <haiyangz@...rosoft.com>
> TO: Wei Liu <wei.liu@...nel.org>
> TO: Dexuan Cui <decui@...rosoft.com>
> TO: linux-hyperv@...r.kernel.org
> TO: Anna-Maria Behnsen <anna-maria@...utronix.de>
> TO: Thomas Gleixner <tglx@...utronix.de>
> TO: Geert Uytterhoeven <geert@...ux-m68k.org>
> TO: Marcel Holtmann <marcel@...tmann.org>
> TO: Johan Hedberg <johan.hedberg@...il.com>
> TO: Luiz Augusto von Dentz <luiz.dentz@...il.com>
> TO: linux-bluetooth@...r.kernel.org
> TO: linux-kernel@...r.kernel.org
> CC: Michael Kelley <mhklinux@...look.com>
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> ---
> drivers/hv/hv_balloon.c | 9 +++++----
> drivers/hv/hv_kvp.c | 4 ++--
> drivers/hv/hv_snapshot.c | 3 ++-
> drivers/hv/vmbus_drv.c | 2 +-
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> index
> c38dcdfcb914dcc3515be100cba0beb4a3f9b975..a99112e6f0b8534cf5c8c963e3430
> 19061bd34f6 100644
> --- a/drivers/hv/hv_balloon.c
> +++ b/drivers/hv/hv_balloon.c
> @@ -756,7 +756,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size,
> * adding succeeded, it is ok to proceed even if the memory was
> * not onlined in time.
> */
> - wait_for_completion_timeout(&dm_device.ol_waitevent, 5 * HZ);
> + wait_for_completion_timeout(&dm_device.ol_waitevent, secs_to_jiffies(5));
> post_status(&dm_device);
> }
> }
> @@ -1373,7 +1373,8 @@ static int dm_thread_func(void *dm_dev)
> struct hv_dynmem_device *dm = dm_dev;
>
> while (!kthread_should_stop()) {
> - wait_for_completion_interruptible_timeout(&dm_device.config_event, 1 * HZ);
> + wait_for_completion_interruptible_timeout(&dm_device.config_event,
> + secs_to_jiffies(1));
> /*
> * The host expects us to post information on the memory
> * pressure every second.
> @@ -1748,7 +1749,7 @@ static int balloon_connect_vsp(struct hv_device *dev)
> if (ret)
> goto out;
>
> - t = wait_for_completion_timeout(&dm_device.host_event, 5 * HZ);
> + t = wait_for_completion_timeout(&dm_device.host_event, secs_to_jiffies(5));
> if (t == 0) {
> ret = -ETIMEDOUT;
> goto out;
> @@ -1806,7 +1807,7 @@ static int balloon_connect_vsp(struct hv_device *dev)
> if (ret)
> goto out;
>
> - t = wait_for_completion_timeout(&dm_device.host_event, 5 * HZ);
> + t = wait_for_completion_timeout(&dm_device.host_event, secs_to_jiffies(5));
> if (t == 0) {
> ret = -ETIMEDOUT;
> goto out;
> diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c
> index
> d35b60c0611486c8c909d2f8f7c730ff913df30d..29e01247a0870fdb9eebd92bdd16f
> d371450240c 100644
> --- a/drivers/hv/hv_kvp.c
> +++ b/drivers/hv/hv_kvp.c
> @@ -655,7 +655,7 @@ void hv_kvp_onchannelcallback(void *context)
> if (host_negotiatied == NEGO_NOT_STARTED) {
> host_negotiatied = NEGO_IN_PROGRESS;
> schedule_delayed_work(&kvp_host_handshake_work,
> - HV_UTIL_NEGO_TIMEOUT * HZ);
> + secs_to_jiffies(HV_UTIL_NEGO_TIMEOUT));
> }
> return;
> }
> @@ -724,7 +724,7 @@ void hv_kvp_onchannelcallback(void *context)
> */
> schedule_work(&kvp_sendkey_work);
> schedule_delayed_work(&kvp_timeout_work,
> - HV_UTIL_TIMEOUT * HZ);
> + secs_to_jiffies(HV_UTIL_TIMEOUT));
>
> return;
>
> diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c
> index
> 0d2184be16912559a8cfa784c762e6418ebd3279..86d87486ed40b3ca9f6674650e5
> a86a7184e2fa6 100644
> --- a/drivers/hv/hv_snapshot.c
> +++ b/drivers/hv/hv_snapshot.c
> @@ -193,7 +193,8 @@ static void vss_send_op(void)
> vss_transaction.state = HVUTIL_USERSPACE_REQ;
>
> schedule_delayed_work(&vss_timeout_work, op == VSS_OP_FREEZE ?
> - VSS_FREEZE_TIMEOUT * HZ : HV_UTIL_TIMEOUT * HZ);
> + secs_to_jiffies(VSS_FREEZE_TIMEOUT) :
> + secs_to_jiffies(HV_UTIL_TIMEOUT));
>
> rc = hvutil_transport_send(hvt, vss_msg, sizeof(*vss_msg), NULL);
> if (rc) {
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index
> 9b15f7daf5059750e17ea3607b52dee967c1c059..7db30881e83ad4b406413641413
> d68329fc663e2 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -2507,7 +2507,7 @@ static int vmbus_bus_resume(struct device *dev)
> vmbus_request_offers();
>
> if (wait_for_completion_timeout(
> - &vmbus_connection.ready_for_resume_event, 10 * HZ) == 0)
> + &vmbus_connection.ready_for_resume_event, secs_to_jiffies(10)) == 0)
> pr_err("Some vmbus device is missing after suspending?\n");
>
> /* Reset the event for the next suspend. */
>
Reviewed-by: Michael Kelley <mhklinux@...look.com>
Powered by blists - more mailing lists