linux-kernel - Re: [PATCH] drm/nouveau/gr/gf100: Fix missing unlock in gf100_gr_chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67c66881-231f-1a35-caab-0a6327365e58@huawei.com>
Date: Thu, 31 Oct 2024 10:04:07 +0800
From: Li Huafei <lihuafei1@...wei.com>
To: Lyude Paul <lyude@...hat.com>, <kherbst@...hat.com>
CC: <dakr@...hat.com>, <airlied@...il.com>, <simona@...ll.ch>,
	<colin.i.king@...il.com>, <rdunlap@...radead.org>, <bskeggs@...hat.com>,
	<dri-devel@...ts.freedesktop.org>, <nouveau@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/nouveau/gr/gf100: Fix missing unlock in
 gf100_gr_chan_new()



On 2024/10/30 2:42, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@...hat.com>
> 
> Will push upstream in a moment
>
Thank you for reviewing.

Thanks,
Huafei
> On Sun, 2024-10-27 at 01:38 +0800, Li Huafei wrote:
>> When the call to gf100_grctx_generate() fails, unlock gr->fecs.mutex
>> before returning the error.
>>
>> Fixes smatch warning:
>>
>> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:480 gf100_gr_chan_new() warn: inconsistent returns '&gr->fecs.mutex'.
>>
>> Fixes: ca081fff6ecc ("drm/nouveau/gr/gf100-: generate golden context during first object alloc")
>> Signed-off-by: Li Huafei <lihuafei1@...wei.com>
>> ---
>>  drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
>> index 060c74a80eb1..3ea447f6a45b 100644
>> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
>> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
>> @@ -443,6 +443,7 @@ gf100_gr_chan_new(struct nvkm_gr *base, struct nvkm_chan *fifoch,
>>  		ret = gf100_grctx_generate(gr, chan, fifoch->inst);
>>  		if (ret) {
>>  			nvkm_error(&base->engine.subdev, "failed to construct context\n");
>> +			mutex_unlock(&gr->fecs.mutex);
>>  			return ret;
>>  		}
>>  	}
>