linux-kernel - Re: [PATCH] ucounts: fix counter leak in inc_rlimit_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyPAmJqCB7EX-Pqh@google.com>
Date: Thu, 31 Oct 2024 17:38:32 +0000
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Andrei Vagin <avagin@...gle.com>
Cc: "Eric W. Biederman" <ebiederm@...ssion.com>,
	Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org,
	Alexey Gladkov <legion@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH] ucounts: fix counter leak in inc_rlimit_get_ucounts()

On Thu, Oct 31, 2024 at 04:56:01AM +0000, Andrei Vagin wrote:
> The inc_rlimit_get_ucounts() increments the specified rlimit counter and
> then checks its limit. If the value exceeds the limit, the function
> returns an error without decrementing the counter.
> 
> Fixes: 15bc01effefe ("ucounts: Fix signal ucount refcounting")
> Tested-by: Roman Gushchin <roman.gushchin@...ux.dev>
> Co-debugged-by: Roman Gushchin <roman.gushchin@...ux.dev>
> Cc: Kees Cook <kees@...nel.org>
> Cc: Andrei Vagin <avagin@...gle.com>
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> Cc: Alexey Gladkov <legion@...nel.org>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Andrei Vagin <avagin@...gle.com>

Acked-by: Roman Gushchin <roman.gushchin@...ux.dev>

Thanks!