| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <vynqe5gqhval4enmnbmamshnu7o5bkpp3fnr7bnyfbgxfm7muc@tn4afxxht7vq>
Date: Thu, 31 Oct 2024 19:51:42 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Barnabás Czémán <barnabas.czeman@...nlining.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Lee Jones <lee@...nel.org>, Amit Kucheria <amitk@...nel.org>,
Thara Gopinath <thara.gopinath@...il.com>, "Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
Lukasz Luba <lukasz.luba@....com>, Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
Robin Murphy <robin.murphy@....com>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, iommu@...ts.linux.dev,
Dang Huynh <danct12@...eup.net>
Subject: Re: [PATCH v2 05/15] arm64: dts: qcom: Add PM8937 PMIC
On Thu, Oct 31, 2024 at 02:19:46AM +0100, Barnabás Czémán wrote:
> From: Dang Huynh <danct12@...eup.net>
>
> The PM8937 features integrated peripherals like ADC, GPIO controller,
> MPPs, PON keys and others.
>
> Add the device tree so that any boards with this PMIC can use it.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Signed-off-by: Dang Huynh <danct12@...eup.net>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
> ---
> arch/arm64/boot/dts/qcom/pm8937.dtsi | 216 +++++++++++++++++++++++++++++++++++
> 1 file changed, 216 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8937.dtsi b/arch/arm64/boot/dts/qcom/pm8937.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..34e2b4cd0d5f4f92c16bb20f53e4520544a644bc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8937.dtsi
> @@ -0,0 +1,216 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Dang Huynh <danct12@...eup.net>
> + */
> +
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-mpp.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +/ {
> + thermal-zones {
> + pm8937-thermal {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
> + thermal-sensors = <&pm8937_temp>;
> +
> + trips {
> + trip0 {
> + temperature = <105000>;
> + hysteresis = <0>;
> + type = "passive";
> + };
> +
> + trip1 {
> + temperature = <125000>;
> + hysteresis = <0>;
> + type = "hot";
> + };
> +
> + trip2 {
> + temperature = <145000>;
> + hysteresis = <0>;
> + type = "critical";
> + };
> + };
> + };
> + };
> +};
> +
> +&spmi_bus {
> + pmic@0 {
> + compatible = "qcom,pm8937", "qcom,spmi-pmic";
> + reg = <0x0 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pon@800 {
> + compatible = "qcom,pm8916-pon";
> + reg = <0x800>;
> + mode-bootloader = <0x2>;
> + mode-recovery = <0x1>;
> +
> + pm8937_pwrkey: pwrkey {
> + compatible = "qcom,pm8941-pwrkey";
> + interrupts = <0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + linux,code = <KEY_POWER>;
> + };
> +
> + pm8937_resin: resin {
> + compatible = "qcom,pm8941-resin";
> + interrupts = <0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + status = "disabled";
> + };
> + };
> +
> + pm8937_gpios: gpio@...0 {
> + compatible = "qcom,pm8937-gpio", "qcom,spmi-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + gpio-ranges = <&pm8937_gpios 0 0 8>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
> + pm8937_mpps: mpps@...0 {
> + compatible = "qcom,pm8937-mpp", "qcom,spmi-mpp";
> + reg = <0xa000>;
> + gpio-controller;
> + gpio-ranges = <&pm8937_mpps 0 0 4>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
> + pm8937_temp: temp-alarm@...0 {
> + compatible = "qcom,spmi-temp-alarm";
> + reg = <0x2400>;
> + interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>;
> + io-channels = <&pm8937_vadc VADC_DIE_TEMP>;
> + io-channel-names = "thermal";
> + #thermal-sensor-cells = <0>;
> + };
> +
> + pm8937_vadc: adc@...0 {
> + compatible = "qcom,spmi-vadc";
> + reg = <0x3100>;
> + interrupts = <0 0x31 0 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #io-channel-cells = <1>;
> +
> + channel@5 {
> + reg = <VADC_VCOIN>;
> + qcom,pre-scaling = <1 1>;
> + label = "vcoin";
Are all the channels available and usable on all the boards?
> + };
> +
> + channel@7 {
> + reg = <VADC_VSYS>;
> + qcom,pre-scaling = <1 1>;
> + label = "vph_pwr";
> + };
> +
> + channel@8 {
> + reg = <VADC_DIE_TEMP>;
> + qcom,pre-scaling = <1 1>;
> + label = "die_temp";
> + };
> +
> + channel@9 {
> + reg = <VADC_REF_625MV>;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_625mv";
> + };
> +
> + channel@a {
> + reg = <VADC_REF_1250MV>;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_1250mv";
> + };
> +
> + channel@c {
> + reg = <VADC_SPARE1>;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_buf_625mv";
> + };
> +
> + channel@e {
> + reg = <VADC_GND_REF>;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_gnd";
> + };
> +
> + channel@f {
> + reg = <VADC_VDD_VADC>;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_vdd";
> + };
> +
> + channel@11 {
> + reg = <VADC_P_MUX2_1_1>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + label = "pa_therm1";
> + };
> +
> + channel@13 {
> + reg = <VADC_P_MUX4_1_1>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + label = "case_therm";
This one looks particularly board-specific. Please move device-specific
channels to the board.dtsi.
> + };
> +
> + channel@32 {
> + reg = <VADC_LR_MUX3_XO_THERM>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + label = "xo_therm";
> + };
> +
> + channel@36 {
> + reg = <VADC_LR_MUX7_HW_ID>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + label = "pa_therm0";
> + };
> +
> + channel@3c {
> + reg = <VADC_LR_MUX3_BUF_XO_THERM>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + label = "xo_therm_buf";
> + };
> + };
> +
> + rtc@...0 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>, <0x6100>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> + };
> + };
> +
> + pmic@1 {
> + compatible = "qcom,pm8937", "qcom,spmi-pmic";
> + reg = <0x1 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pm8937_spmi_regulators: regulators {
> + compatible = "qcom,pm8937-regulators";
> + };
> + };
> +};
>
> --
> 2.47.0
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists