lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e2ce5f7a-6ef5-45e0-9868-11eb9106ace8@kernel.org>
Date: Thu, 31 Oct 2024 19:06:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrea della Porta <andrea.porta@...e.com>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczynski <kw@...ux.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Linus Walleij
 <linus.walleij@...aro.org>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic
 <dragan.cvetic@....com>, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Saravana Kannan <saravanak@...gle.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-gpio@...r.kernel.org,
 Masahiro Yamada <masahiroy@...nel.org>, Stefan Wahren <wahrenst@....net>,
 Herve Codina <herve.codina@...tlin.com>,
 Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v3 03/12] dt-bindings: pci: Add common schema for devices
 accessible through PCI BARs

On 31/10/2024 15:20, Andrea della Porta wrote:
> Hi Krzysztof,
> 
> On 08:28 Tue 29 Oct     , Krzysztof Kozlowski wrote:
>> On Mon, Oct 28, 2024 at 03:07:20PM +0100, Andrea della Porta wrote:
>>> Common YAML schema for devices that exports internal peripherals through
>>> PCI BARs. The BARs are exposed as simple-buses through which the
>>> peripherals can be accessed.
>>>
>>> This is not intended to be used as a standalone binding, but should be
>>> included by device specific bindings.
>>>
>>> Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
>>> ---
>>>  .../devicetree/bindings/pci/pci-ep-bus.yaml   | 58 +++++++++++++++++++
>>>  MAINTAINERS                                   |  1 +
>>>  2 files changed, 59 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/pci/pci-ep-bus.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/pci-ep-bus.yaml b/Documentation/devicetree/bindings/pci/pci-ep-bus.yaml
>>> new file mode 100644
>>> index 000000000000..e532621f226b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pci/pci-ep-bus.yaml
>>> @@ -0,0 +1,58 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pci/pci-ep-bus.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Common Properties for PCI MFD Endpoints with Peripherals Addressable from BARs
>>> +
>>> +maintainers:
>>> +  - Andrea della Porta  <andrea.porta@...e.com>
>>> +
>>> +description:
>>> +  Define a generic node representing a PCI endpoint which contains several sub-
>>> +  peripherals. The peripherals can be accessed through one or more BARs.
>>> +  This common schema is intended to be referenced from device tree bindings, and
>>
>> Please wrap code according to coding style (checkpatch is not a coding
>> style description but only a tool).
>>
>> Above applies to all places here and other bindings.
> 
> Are you referring to the title being longer than 80 column here, right?
> Because the description seems correctly wrapped... or should I add a
> newline for each paragraph?

Hmm, I might commented on wrong description. I just looked at patch #2
and there it's passed 80.

Here the title is not wrapped.

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ