linux-kernel - Re: [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyPUWaINgupm7dZ3@lizhi-Precision-Tower-5810>
Date: Thu, 31 Oct 2024 15:02:49 -0400
From: Frank Li <Frank.li@....com>
To: Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	"open list:WATCHDOG DEVICE DRIVERS" <linux-watchdog@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing
 'big-endian' property

On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> From: Animesh Agarwal <animeshagarwal28@...il.com>
>
> Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> allow big-endian property for ls1012a and ls1043a.
>
> Fix dtbs_check errors.
> arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@...0000:
>     Unevaluated properties are not allowed ('big-endian' was unexpected)
>
> Cc: Daniel Baluta <daniel.baluta@....com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---

Wim Van Sebroeck:

	Any update this patch? Kyzy already acked.


Frank


>
> Change from v1 to v2:
>   only allow big endian for layerscape platform.
>
> previous post at:
> https://lore.kernel.org/imx/20240806103819.10890-1-animeshagarwal28@gmail.com/
>
> check spec, and dump watch dog reset value
> at ls1043a platform.
>
> 0x02A80000:  00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
>
> It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
> to handle endian.
>
> So this change is corret.
>
> big-endian for wdt is necessary
> ---
>  .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index 36b836d0620c9..0da953cb71272 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -48,6 +48,8 @@ properties:
>    clocks:
>      maxItems: 1
>
> +  big-endian: true
> +
>    fsl,ext-reset-output:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description: |
> @@ -93,6 +95,18 @@ allOf:
>        properties:
>          fsl,suspend-in-wait: false
>
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - fsl,ls1012a-wdt
> +                - fsl,ls1043a-wdt
> +    then:
> +      properties:
> +        big-endian: false
> +
>  unevaluatedProperties: false
>
>  examples:
> --
> 2.34.1
>