linux-kernel - Re: [PATCH v1] iio: chemical: bme680: use s16 variable for temp value to avoid casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241031192200.649a0ea1@jic23-huawei>
Date: Thu, 31 Oct 2024 19:22:00 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: dan.carpenter@...aro.org, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] iio: chemical: bme680: use s16 variable for temp
 value to avoid casting

On Thu, 31 Oct 2024 00:54:24 +0100
Vasileios Amoiridis <vassilisamir@...il.com> wrote:

> Use local s16 variable for the temperature channel to avoid casting it
> later before passing it to the bme680_read_temp() function. This way,
> possible endianness and initialization issues are avoided.
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>

Applied.

> ---
>  drivers/iio/chemical/bme680_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
> index 871921d81e70..6d11f9188367 100644
> --- a/drivers/iio/chemical/bme680_core.c
> +++ b/drivers/iio/chemical/bme680_core.c
> @@ -741,6 +741,7 @@ static int bme680_read_raw(struct iio_dev *indio_dev,
>  {
>  	struct bme680_data *data = iio_priv(indio_dev);
>  	int chan_val, ret;
> +	s16 temp_chan_val;
>  
>  	guard(mutex)(&data->lock);
>  
> @@ -757,11 +758,11 @@ static int bme680_read_raw(struct iio_dev *indio_dev,
>  	case IIO_CHAN_INFO_PROCESSED:
>  		switch (chan->type) {
>  		case IIO_TEMP:
> -			ret = bme680_read_temp(data, (s16 *)&chan_val);
> +			ret = bme680_read_temp(data, &temp_chan_val);
>  			if (ret)
>  				return ret;
>  
> -			*val = chan_val * 10;
> +			*val = temp_chan_val * 10;
>  			return IIO_VAL_INT;
>  		case IIO_PRESSURE:
>  			ret = bme680_read_press(data, &chan_val);