linux-kernel - Re: [PATCH] rtc: mediatek: Add mt6685 RTC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <976d64da-d6e3-4bd9-af57-d475d9939410@web.de>
Date: Thu, 31 Oct 2024 20:50:36 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-rtc@...r.kernel.org, Alexandre Belloni
 <alexandre.belloni@...tlin.com>,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Lee Jones <lee@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: mediatek: Add mt6685 RTC driver

Please add a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n45

…
> +++ b/drivers/rtc/rtc-mt6685.c
> @@ -0,0 +1,1456 @@
…
> +static void power_on_mclk(struct mt6685_rtc *rtc)
> +{
> +	mutex_lock(&rtc->clk_lock);
…
> +	mdelay(1);
> +	mutex_unlock(&rtc->clk_lock);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&rtc->clk_lock);”?
https://elixir.bootlin.com/linux/v6.12-rc5/source/include/linux/mutex.h#L201

Regards,
Markus