linux-kernel - [PATCH -next] mm: shmem: Fix an incorrect type in shmem_parse_opt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241031030025.32217-1-jiapeng.chong@linux.alibaba.com>
Date: Thu, 31 Oct 2024 11:00:25 +0800
From: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
To: hughd@...gle.com
Cc: akpm@...ux-foundation.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: [PATCH -next] mm: shmem: Fix an incorrect type in shmem_parse_opt_casefold()

The return value from the call to utf8_parse_version() is int.
However, the return value is being assigned to an unsiged int
variable 'version', so making 'version' an int.

./mm/shmem.c:4368:6-13: WARNING: Unsigned expression compared with zero: version < 0.

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11587
Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
---
 mm/shmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 3560188fe329..a1835f528581 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -4355,7 +4355,7 @@ static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter *
 				    bool latest_version)
 {
 	struct shmem_options *ctx = fc->fs_private;
-	unsigned int version = UTF8_LATEST;
+	int version = UTF8_LATEST;
 	struct unicode_map *encoding;
 	char *version_str = param->string + 5;
 
-- 
2.32.0.3.g01195cf9f