linux-kernel - Re: [PATCH v6 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for WDK2023

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <108c5fb7-fe36-4d07-979e-409cd4539879@oldschoolsolutions.biz>
Date: Thu, 31 Oct 2024 21:22:58 +0100
From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Kalle Valo <kvalo@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Merck Hung <merckhung@...il.com>
Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt
 definition for WDK2023

On 31.10.24 21:15, Konrad Dybcio wrote:
> On 30.10.2024 12:02 PM, Jens Glathe via B4 Relay wrote:
>> From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>>
>> Device tree for the Microsoft Windows Dev Kit 2023. This work
>> is based on the initial work of Merck Hung <merckhung@...il.com>.
>>
>> Original work: https://github.com/merckhung/linux_ms_dev_kit/blob/ms-dev-kit-2023-v6.3.0/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-dev-kit-2023.dts
>>
>> The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp.
>> Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/
>>
>> Supported features:
>> - USB type-c and type-a ports
>> - minidp connector
>> - built-in r8152 Ethernet adapter
>> - PCIe devices
>> - nvme
>> - ath11k WiFi (WCN6855)
>> - WCN6855 Bluetooth
>> - A690 GPU
>> - ADSP and CDSP
>> - GPIO keys
>> - Audio definition (works via USB)
>>
>> Signed-off-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>> ---
> [...]
>
>> +	wcn6855-pmu {
>> +		compatible = "qcom,wcn6855-pmu";
>> +
>> +		pinctrl-0 = <&bt_default>, <&wlan_en>;
>> +		pinctrl-names = "default";
>> +
>> +		wlan-enable-gpios = <&tlmm 134 GPIO_ACTIVE_HIGH>;
>> +		bt-enable-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
>> +
>> +		vddio-supply = <&vreg_s10b>;
>> +		vddaon-supply = <&vreg_s12b>;
>> +		vddpmu-supply = <&vreg_s12b>;
>> +		vddrfa0p95-supply = <&vreg_s12b>;
>> +		vddrfa1p3-supply = <&vreg_s11b>;
>> +		vddrfa1p9-supply = <&vreg_s1c>;
>> +		vddpcie1p3-supply = <&vreg_s11b>;
>> +		vddpcie1p9-supply = <&vreg_s1c>;
> Please update this atop
>
> <20241018-sc8280xp-pwrseq-v6-0-8da8310d9564@...aro.org>
>
> most notably including a new supply (which will likely be identical)

okay, thanks

>> +	compatible = "qcom,sc8280xp-sndcard";
>> +	model = "microsoft/blackrock";
>> +	audio-routing =
> Please don't break the line, see e.g. x1e80100-crd.dts
>
>> +		"SpkrLeft IN", "WSA_SPK1 OUT",
>> +		"SpkrRight IN", "WSA_SPK2 OUT",
> Oh, this thing has a speaker!

Well, no. Will take another look at it. Interestingly, the SnapDragon
Dev Kit (x1e) has a panel for speakers. So, maybe they are there on an
unused panel.

> [...]
>
>> +&pmc8280_1_gpios {
>> +	edp_bl_en: edp-bl-en-state {
>> +		pins = "gpio8";
>> +		function = "normal";
>> +	};
>> +
>> +	edp_bl_reg_en: edp-bl-reg-en-state {
>> +		pins = "gpio9";
>> +		function = "normal";
>> +	};
>> +
>> +	misc_3p3_reg_en: misc-3p3-reg-en-state {
>> +		pins = "gpio1";
>> +		function = "normal";
>> +	};
> Sorting GPIOs by their number is preferred
>
> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes
>
> [...]
Will sort.
>> +&tlmm {
>> +	gpio-reserved-ranges = <70 2>, <74 6>, <125 2>, <128 2>, <154 4>;
> Do we know what these are for? If so, please describe it (also
> like in x1e80100-crd.dts)
>
> Konrad

Will check and amend if necessary.

with best regards

Jens