linux-kernel - Re: [PATCH v3 5/5] arm64: dts: qcom: qrb4210-rb2: add HDMI audio playback support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D5ACVOXF0KJK.1ZUDOAK4X9EP8@linaro.org>
Date: Thu, 31 Oct 2024 22:47:58 +0000
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "Konrad Dybcio" <konrad.dybcio@....qualcomm.com>,
 <linux-sound@...r.kernel.org>, <srinivas.kandagatla@...aro.org>,
 <broonie@...nel.org>
Cc: <lgirdwood@...il.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
 <conor+dt@...nel.org>, <andersson@...nel.org>, <konradybcio@...nel.org>,
 <perex@...ex.cz>, <tiwai@...e.com>, <linux-arm-msm@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <dmitry.baryshkov@...aro.org>,
 <krzysztof.kozlowski@...aro.org>, <caleb.connolly@...aro.org>,
 <linux-kernel@...r.kernel.org>, <a39.skl@...il.com>
Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: qrb4210-rb2: add HDMI audio
 playback support

On Fri Oct 25, 2024 at 8:09 PM BST, Konrad Dybcio wrote:
> On 18.10.2024 4:54 AM, Alexey Klimov wrote:
> > Add sound node and dsp-related piece to enable HDMI audio
> > playback support on Qualcomm QRB4210 RB2 board. That is the
> > only sound output supported for now.
> > 
> > The audio playback is verified using the following commands:
> > 
> > amixer -c0 cset iface=MIXER,name='SEC_MI2S_RX Audio Mixer MultiMedia1' 1
> > aplay -D hw:0,0 /usr/share/sounds/alsa/Front_Center.wav
> > 
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 55 ++++++++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> > index 1888d99d398b..5f671b9c8fb9 100644
> > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> > @@ -6,6 +6,8 @@
> >  /dts-v1/;
> >  
> >  #include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/sound/qcom,q6afe.h>
> > +#include <dt-bindings/sound/qcom,q6asm.h>
> >  #include <dt-bindings/usb/pd.h>
> >  #include "sm4250.dtsi"
> >  #include "pm6125.dtsi"
> > @@ -103,6 +105,51 @@ led-wlan {
> >  		};
> >  	};
> >  
> > +	sound {
> > +		compatible = "qcom,qrb4210-rb2-sndcard";
> > +		pinctrl-0 = <&lpi_i2s2_active>;
> > +		pinctrl-names = "default";
> > +		model = "Qualcomm-RB2-WSA8815-Speakers-DMIC0";
> > +		audio-routing = "MM_DL1",  "MultiMedia1 Playback",
> > +				"MM_DL2",  "MultiMedia2 Playback";
>
> I'm seeing a lot of double spaces in this patch
>
> > +
> > +		mm1-dai-link {
> > +			link-name = "MultiMedia1";
> > +			cpu {
>
> Please add a newline between the subnode
>
> Looks nice otherwise

Thanks for noticing this! I'll update it and resend.
I put one space between audio-routing widgets, not sure if even one
is needed though, maybe there should be no space at all.

Best regards,
Alexey